Bad patch to test static analysis + linting
Needs ReviewPublic
Actions

Authored by • smacleod on Mar 26 2019, 2:03 PM.

Details

Reviewers

Unknown Object (User)

Bugzilla Bug ID

Not provided

Summary

TWO MORE TIMES?

	Time	Test
	7,457 ms	code-review::general WARNING: An error occurred in the code review bot. Failed to update to revision central

Unknown Object (User) created this revision.Mar 26 2019, 2:03 PM

phab-bot requested review of this revision.Mar 26 2019, 2:03 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

• smacleod edited the summary of this revision. (Show Details)

Checking herald behaviors.

• smacleod edited the summary of this revision. (Show Details)

Checking herald behaviors. AGAIN AGAIN

• smacleod updated this revision to Diff 1843.

• smacleod edited the summary of this revision. (Show Details)

• smacleod added a reviewer: Unknown Object (User).

Checking herald behaviors. AGAIN AGAIN

Unknown Object (User) set the repository for this revision to rMOZILLACENTRAL mozilla-central.Apr 3 2019, 7:35 AM

This is a warning using WARNING:

WARNING: test warning.

This is an error using (IMPORTANT)

ERROR: test error

js/src/jsapi.cpp
210	Warning: Variable 'x' with floating point type 'float' should not be used as a loop counter [clang-tidy: clang-analyzer-security.FloatLoopCounter]
217	Warning: Statement should be inside braces [clang-tidy: readability-braces-around-statements]