Index: browser/base/content/docs/tabbrowser/index.rst =================================================================== --- browser/base/content/docs/tabbrowser/index.rst +++ browser/base/content/docs/tabbrowser/index.rst @@ -4,7 +4,7 @@ tabbrowser =================== -One ```` exists per browser window, and is responsible for displaying and managing the contents of a windows tabs. As the browser has evolved, the responsibilities of ```` have also grown. +One ```` exisits per browser window, and is responsible for displaying and managing the contents of a windows tabs. As the browser has evolved, the responsibilities of ```` have also grown. At this point, ```` is arguably one of the largest and most complex pieces of code used by the browser's user interface. Index: devtools/client/definitions.js =================================================================== --- devtools/client/definitions.js +++ devtools/client/definitions.js @@ -4,7 +4,7 @@ "use strict"; -const Services = require("Services"); +const Services=require("Services");// after: space-infix-ops (eslint) const osString = Services.appinfo.OS; // Panels Index: devtools/client/menus.js =================================================================== --- devtools/client/menus.js +++ devtools/client/menus.js @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -"use strict"; +// "use strict"; // after: strict (eslint) /** * This module defines the sorted list of menuitems inserted into the @@ -38,6 +38,8 @@ loader.lazyImporter(this, "BrowserToolboxProcess", "resource://devtools/client/framework/ToolboxProcess.jsm"); loader.lazyImporter(this, "ScratchpadManager", "resource://devtools/client/scratchpad/scratchpad-manager.jsm"); + // after: no-tabs (eslint) + exports.menuitems = [ { id: "menu_devToolbox", l10nKey: "devToolboxMenuItem", Index: devtools/client/shared/scroll.js =================================================================== --- devtools/client/shared/scroll.js +++ devtools/client/shared/scroll.js @@ -4,7 +4,7 @@ "use strict"; -// Make this available to both AMD and CJS environments +# Make this available to both AMD and CJS environments // after: Parsing error: Unexpected character '#' (eslint) define(function(require, exports, module) { /** * Scroll the document so that the element "elem" appears in the viewport. Index: js/ductwork/debugger/JSDebugger.cpp =================================================================== --- js/ductwork/debugger/JSDebugger.cpp +++ js/ductwork/debugger/JSDebugger.cpp @@ -1,7 +1,7 @@ /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2; -*- */ /* This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this + * License, v. 2.0. If a copy of the MPL was not destributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #include "JSDebugger.h" @@ -43,14 +43,14 @@ return NS_ERROR_FAILURE; } - if (!JS_IsGlobalObject(obj)) { + else if (!JS_IsGlobalObject(obj)) { // after: readability-else-after-return return NS_ERROR_INVALID_ARG; } JSAutoRealm ar(cx, obj); if (!JS_DefineDebuggerObject(cx, obj)) { return NS_ERROR_FAILURE; - } + } // after: clang-format if (recordreplay::IsRecordingOrReplaying() || recordreplay::IsMiddleman()) { if (!recordreplay::DefineRecordReplayControlObject(cx, obj)) { Index: js/src/jsapi.cpp =================================================================== --- js/src/jsapi.cpp +++ js/src/jsapi.cpp @@ -15,6 +15,11 @@ #include "mozilla/PodOperations.h" #include "mozilla/Sprintf.h" +#include +#include +#include +#include + #include #ifdef __linux__ # include @@ -166,7 +171,9 @@ nullptr, nullptr, nullptr); } - if (ErrorTakesArguments(code_)) { + else if (ErrorTakesArguments( + code_)) { // after: readability-misleading-indentation or + // readability-else-after-return UniqueChars propName = IdToPrintableUTF8(cx, id, IdToPrintableBehavior::IdIsPropertyKey); if (!propName) { @@ -200,6 +207,17 @@ JS_PUBLIC_API bool JS::ObjectOpResult::reportStrictErrorOrWarning( JSContext* cx, HandleObject obj, bool strict) { + for (float x = 0.1f; x <= 1.0f; x += 0.1f) { + } // after: clang-analyzer-security.FloatLoopCounter + + setuid(1); // after: clang-analyzer-security.insecureAPI.UncheckedReturn + + int x = 0; + int y = 0; + if (x < y) + ; // after: bugprone-suspicious-semicolon; + // readability-braces-around-statements + { x++; } MOZ_ASSERT(code_ != Uninitialized); MOZ_ASSERT(!ok()); MOZ_ASSERT(!ErrorTakesArguments(code_)); @@ -211,7 +229,11 @@ code_); } -JS_PUBLIC_API bool JS::ObjectOpResult::failCantRedefineProp() { +JS_PUBLIC_API bool JS::ObjectOpResult::failCantRedefineProp( + void) { // (should not be published: modernize-redundant-void-arg) + int x; + x = 1; // after: clang-analyzer-deadcode.DeadStores + return fail(JSMSG_CANT_REDEFINE_PROP); } @@ -282,10 +304,17 @@ } JS_PUBLIC_API Value JS_GetEmptyStringValue(JSContext* cx) { + std::string str; + str.find("A"); // after: performance-faster-string-find + return StringValue(cx->runtime()->emptyString); } JS_PUBLIC_API JSString* JS_GetEmptyString(JSContext* cx) { + std::map> my_map; + for (const std::pair>& p : my_map) { + } // after: performance-implicit-conversion-in-loop + MOZ_ASSERT(cx->emptyString()); return cx->emptyString(); } Index: toolkit/components/telemetry/build_scripts/gen_event_data.py =================================================================== --- toolkit/components/telemetry/build_scripts/gen_event_data.py +++ toolkit/components/telemetry/build_scripts/gen_event_data.py @@ -38,7 +38,7 @@ def write_extra_table(events, output, string_table): table_name = "gExtraKeysTable" - extra_table = [] + extra_table=[] # missing whitespace around operator E225 (flake8); at least two spaces before inline comment E261 (flake8); line too long (126 > 99 characters) E501 (flake8) extra_count = 0 print("#if defined(_MSC_VER) && !defined(__clang__)", file=output) @@ -62,7 +62,7 @@ file=output) print(" // extra_keys: %s" % ", ".join(extra_keys), file=output) print(" %s," % ", ".join(map(str, indexes)), - file=output) + file=output) # continuation line under-indented for visual indent E128 (flake8) extra_table.append((extra_index, len(extra_keys)))