Page MenuHomePhabricator Dev

Bug 1595929 - [WIP] Implement dynamic performance testing docs. r?AlexandruIonescu
Needs ReviewPublic

Authored by Unknown Object (User) on Nov 14 2019, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:03 AM
Unknown Object (File)
Wed, Oct 7, 3:55 AM
Unknown Object (File)
Aug 7 2026, 6:34 PM
Unknown Object (File)
Aug 7 2026, 6:32 PM
Unknown Object (File)
Jun 24 2026, 12:56 PM
Unknown Object (File)
Jun 17 2026, 1:11 PM
Unknown Object (File)
Jun 16 2026, 12:02 PM
Unknown Object (File)
Jun 16 2026, 4:43 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
Not provided
Summary

Code review bot debug clone.

Diff Detail

Event Timeline

Unknown Object (User) created this revision.Nov 14 2019, 2:39 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Unknown Object (User) added a comment.Nov 14 2019, 3:18 PM

Code analysis found 14 defects in the diff 2471:

  • 2 defects found by a generic analyzer
  • 12 defects found by mozlint

You can run this analysis locally with:

  • ./mach lint --warnings path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here.

testing/raptor/raptor/structdoc/config.yml
1

Error: Could not find an existing test for raptor-not-a-test - bad test name? [structdocs-verify]

1

Error: For framework raptor we found 13 tests/suites with missing descriptions: ['scenario', 'raptor-assorted-dom', 'raptor-ares6', 'raptor-jetstream2', 'raptor-motionmark-animometer', 'raptor-motionmark-htmlsuite', 'raptor-speedometer', 'raptor-stylebench', 'raptor-sunspider', 'raptor-unity-webgl', 'raptor-youtube-playback', 'raptor-youtube-playback-v9', 'raptor-youtube-playback-h264'] [structdocs-verify]

testing/structdocs/structdocs/gatherer.py
3

Error: 'glob' imported but unused [flake8: F401]

127

Error: Continuation line under-indented for visual indent [flake8: E128]

testing/structdocs/structdocs/structdocs.py
17

Error: 'glob' imported but unused [flake8: F401]

77

Error: Local variable 'e' is assigned to but never used [flake8: F841]

testing/structdocs/structdocs/utils.py
3

Error: 'glob' imported but unused [flake8: F401]

testing/structdocs/structdocs/verifier.py
3

Error: 'glob' imported but unused [flake8: F401]

4

Error: 'json' imported but unused [flake8: F401]

8

Error: 'jsonschema.ValidationError' imported but unused [flake8: F401]

84

Error: Blank line contains whitespace [flake8: W293]

84

Error: Trailing whitespace [file-whitespace: source-test-mozlint-file-whitespace]

125

Error: Line too long (108 > 99 characters) [flake8: E501]

196

Error: Local variable 'test_list' is assigned to but never used [flake8: F841]

Unknown Object (User) added a comment.Nov 14 2019, 3:46 PM

Code analysis found 1 defect in the diff 2471:

  • 1 defect found by a generic analyzer

If you see a problem in this automated review, please report it here.

taskcluster/ci/source-test/node.yml
1

Error: This is a full file test on a non expanded file [this-is-a-test]

Unknown Object (User) added a comment.Nov 14 2019, 3:47 PM

Code analysis found 1 defect in the diff 2471:

  • 1 defect found by a generic analyzer

If you see a problem in this automated review, please report it here.

taskcluster/ci/source-test/node.yml
1

Error: This is a full file test on a non expanded file [this-is-a-test]

Unknown Object (User) added a comment.Nov 14 2019, 3:49 PM

Code analysis found 1 defect in the diff 2471:

  • 1 defect found by a generic analyzer

If you see a problem in this automated review, please report it here.

taskcluster/ci/source-test/node.yml
1

Error: This is a full file test on a non expanded file [this-is-a-test]

Unknown Object (User) added a comment.Nov 14 2019, 3:50 PM

Code analysis found 1 defect in the diff 2471:

  • 1 defect found by a generic analyzer

If you see a problem in this automated review, please report it here.

taskcluster/ci/source-test/node.yml
1

Error: This is a full file test on a non expanded file [this-is-a-test]