Page MenuHomePhabricator Dev
Differential D1766

test r?mitchhentges
AbandonedPublic
Actions

Authored by • mitchhentges-test on Mar 30 2020, 6:48 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:03 AM
Unknown Object (File)
Thu, Oct 1, 6:47 AM
Unknown Object (File)
Thu, Sep 24, 1:07 AM
Unknown Object (File)
Aug 4 2026, 7:20 AM
Unknown Object (File)
Aug 2 2026, 12:56 AM
Unknown Object (File)
Jul 23 2026, 6:41 PM
Unknown Object (File)
Jul 22 2026, 12:02 AM
Unknown Object (File)
Jul 20 2026, 8:15 AM
View All 23 Files
Subscribers
phabqareview

Details

Reviewers
mitchhentges
• mitchhentges-admin
• test
Bugzilla Bug ID
Not provided

Diff Detail

Repository
rTEST test
Branch
default
Build Status
Buildable 2504
Build 4096: Analysis

Event Timeline

• mitchhentges-test created this revision.Mar 30 2020, 6:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 30 2020, 6:48 PM
Harbormaster completed remote builds in B2502: Diff 2951.Mar 30 2020, 6:48 PM
phab-bot requested review of this revision.Mar 30 2020, 6:48 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
Herald added a subscriber: phabqareview. · View Herald TranscriptMar 30 2020, 6:48 PM
• mitchhentges-test removed a reviewer: mitchhentges.Mar 30 2020, 7:34 PM
• mitchhentges-test updated the bug number.
• mitchhentges-test added reviewers: mitchhentges, • mitchhentges-admin, • test.
• mitchhentges-test updated this revision to Diff 2953.Mar 30 2020, 7:35 PM
Harbormaster completed remote builds in B2504: Diff 2953.Mar 30 2020, 7:35 PM
• mitchhentges-admin accepted this revision.Mar 30 2020, 7:46 PM
• mitchhentges-admin added inline comments.
brownbag/revisions.py
28

Are you sure that we need asyncio?

mitchhentges accepted this revision.Mar 30 2020, 7:48 PM

Send it 🚀

brownbag/revisions.py
28

Yeah, looks like he used asyncio here to allow processing mail queues in parallel.

36

Incredible class here, wow 👏

This revision is now accepted and ready to land.Mar 30 2020, 7:48 PM
• mitchhentges-test abandoned this revision.Mar 30 2020, 9:25 PM

Revision Contents
Changeset List

PathSize
1 line
brownbag/
9 lines
t3/
8 lines

Diff 2953

View Options

b

Loading...
View Options

brownbag/revisions.py

Loading...
View Options

brownbag/t3/revisions.py

Loading...
View Options

test-log.txt

Loading...
Privacy · Cookies · Legal