Details
- Reviewers
- None
- Bugzilla Bug ID
- 1387052
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Branch
- validate-clang-format
Event Timeline
| devtools/client/definitions.js | ||
|---|---|---|
| 7 | Error: Infix operators must be spaced. [eslint: space-infix-ops] | |
| devtools/client/menus.js | ||
| 31 | Error: Use the global form of 'use strict'. [eslint: strict] | |
| 42 | Error: Unexpected tab character. [eslint: no-tabs] | |
| devtools/client/shared/scroll.js | ||
| 7 | Error: Parsing error: Unexpected character '#' [eslint] | |
| js/ductwork/debugger/JSDebugger.cpp | ||
| 53 | Warning: Do not use 'else' after 'return' [clang-tidy: readability-else-after-return] | |
| 56–59 | Warning: Incorrect coding style [clang-format] JSAutoRealm ar(cx, obj);
if (!JS_DefineDebuggerObject(cx, obj)) {
return NS_ERROR_FAILURE;
} // after: clang-format | |
| js/src/jsapi.cpp | ||
| 24–25 | Warning: Incorrect coding style [clang-format] #ifdef linux | |
| 135–138 | Warning: Incorrect coding style [clang-format] class AnnotateConflict MOZ_NO_DANGLING_ON_TEMPORARIES int* get() &&
{
return nullptr;
} // mozilla-dangling-on-temporary
MOZ_NO_DANGLING_ON_TEMPORARIES int test() { return 0; } // mozilla-dangling-on-temporary | |
| 173–174 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, HandleId id, | |
| 206–208 | Warning: Incorrect coding style [clang-format] } return ReportValueErrorFlags( cx, flags, code_, JSDVG_IGNORE_STACK, val, nullptr, propName.ptr(), nullptr); | |
| 225 | Warning: Variable 'x' with floating point type 'float' should not be used as a loop counter [clang-tidy: clang-analyzer-security.FloatLoopCounter] for (float x = 0.1f; x <= 1.0f; x += 0.1f) {} // clang-analyzer-security.FloatLoopCounter
^ | |
| 230–231 | Warning: Incorrect coding style [clang-format] int y = 0;
if (x < y)
; // misc-suspicious-semicolon | |
| 232–233 | Warning: Incorrect coding style [clang-format] {
x++; | |
| 249 | Warning: Value stored to 'x' is never read [clang-tidy: clang-analyzer-deadcode.DeadStores] x = 1; // clang-analyzer-deadcode.DeadStores ^ | |
| 356–357 | Warning: Incorrect coding style [clang-format] std::map<int, std::vector<std::string>> my_map;
for (const std::pair<int, std::vector<std::string>>& p : my_map) {
} // performance-implicit-conversion-in-loop | |
| 498–500 | Warning: Incorrect coding style [clang-format] { return fun->isBoundFunction() ? fun->getBoundFunctionTarget() : nullptr; | |
| 742–746 | Warning: Incorrect coding style [clang-format] JSAutoRealm::JSAutoRealm(JSContext* cx, JSScript* target MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL) : cx_(cx) , oldRealm_(cx->realm()) | |
| 759–762 | Warning: Incorrect coding style [clang-format] JSObject* targetOrNull
MOZ_GUARD_OBJECT_NOTIFIER_PARAM_IN_IMPL)
: cx_(cx)
, oldRealm_(cx->realm()) | |
| 1380–1391 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) // Currently, we only collect nursery during idle time. return rt->gc.nursery().needIdleTimeCollection(); } JS_PUBLIC_API(void) GCRuntime& gc = rt->gc;
if (gc.nursery().needIdleTimeCollection()) {
gc.minorGC(JS::gcreason::IDLE_TIME_COLLECTION);
} | |
| 1501–1502 | Warning: Incorrect coding style [clang-format] static const size_t NumGCConfigs = 14; | |
| 1550–1551 | Warning: Incorrect coding style [clang-format] | |
| 1570–1572 | Warning: Incorrect coding style [clang-format] extern JS_PUBLIC_API(bool) JS_IsExternalString(JSString* str) | |
| 1676–1677 | Warning: Incorrect coding style [clang-format] if (!args.get(0).isString()) {
JS_ReportErrorNumberASCII(cx,
GetErrorMessage,
nullptr,
JSMSG_NOT_EXPECTED_TYPE, | |
| 1679 | Warning: Escaped string literal can be written as a raw string literal [clang-tidy: modernize-raw-string-literal] "\"string\", \"number\", or \"default\"",
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
R"("string", "number", or "default")" | |
| 1721–1725 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(JSObject*) HandleObject obj, HandleObject parent_proto, const JSClass* clasp, JSNative constructor, unsigned nargs, const JSPropertySpec* ps, const JSFunctionSpec* fs, const JSPropertySpec* static_ps, const JSFunctionSpec* static_fs) | |
| 1729–1731 | Warning: Incorrect coding style [clang-format] assertSameCompartment(cx, obj, parent_proto); return InitClass( cx, obj, parent_proto, Valueify(clasp), constructor, nargs, ps, fs, static_ps, static_fs); | |
| 2116–2118 | Warning: Incorrect coding style [clang-format] static bool HandleObject obj, HandleId id, Handle<PropertyDescriptor> desc, ObjectOpResult& result) | |
| 2307–2308 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, const char* name, HandleValue value, | |
| 2377–2381 | Warning: Incorrect coding style [clang-format] #define AUTO_NAMELEN(s, n) (((n) == (size_t)-1) ? js_strlen(s) : (n)) JS_PUBLIC_API(bool) HandleObject obj, const char16_t* name, size_t namelen, | |
| 2405–2407 | Warning: Incorrect coding style [clang-format] static bool HandleObject obj, const char16_t* name, size_t namelen, HandleValue value, unsigned attrs) | |
| 2434–2436 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, const char16_t* name, size_t namelen, HandleObject valueArg, unsigned attrs) | |
| 2442–2444 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, const char16_t* name, size_t namelen, HandleString valueArg, unsigned attrs) | |
| 2497–2499 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, uint32_t index, HandleObject getter, HandleObject setter, unsigned attrs) | |
| 2507–2508 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleObject obj, uint32_t index, HandleObject valueArg, | |
| 2932–2933 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleValue fval, HandleObject newTarget, const JS::HandleValueArray& args, | |
| 2958–2959 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) HandleValue fval, const JS::HandleValueArray& args, | |
| 3081–3083 | Warning: Incorrect coding style [clang-format] static bool HandleObject obj, HandleId id, const char* getterName, const char* setterName, | |
| 3247–3248 | Warning: Incorrect coding style [clang-format] if (ps->isSelfHosted()) {
if (!DefineSelfHostedProperty(cx,
obj,
id, | |
| 3457–3459 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(JSFunction*) | |
| 3520–3523 | Warning: Incorrect coding style [clang-format] RootedValue funVal(cx);
if (!GlobalObject::getSelfHostedFunction(
cx, cx->global(), shName, name, fs->nargs, &funVal)) { | |
| 3644–3647 | Warning: Incorrect coding style [clang-format] if (CanReuseScriptForClone(cx->realm(), fun, env)) {
// If the script is to be reused, either the script can already handle
// non-syntactic scopes, or there is only the standard global lexical
// scope. | |
| 3678–3680 | Warning: Incorrect coding style [clang-format] extern JS_PUBLIC_API(JSObject*) JS::CloneFunctionObject(JSContext* cx, HandleObject funobj, AutoObjectVector& envChain) | |
| 3788–3789 | Warning: Incorrect coding style [clang-format] #if defined(HAVE_GETC_UNLOCKED) | |
| 3833–3834 | Warning: Incorrect coding style [clang-format] : fp_(nullptr)
{
} | |
| 3927–3929 | Warning: Incorrect coding style [clang-format] { return mallocSizeOf(filename_) + mallocSizeOf(sourceMapURL_) + | |
| 4008–4010 | Warning: Incorrect coding style [clang-format] JS::CompileOptions::CompileOptions(JSContext* cx) : ReadOnlyCompileOptions() , elementRoot(cx) , elementAttributeNameRoot(cx) , introductionScriptRoot(cx) | |
| 4069–4070 | Warning: Incorrect coding style [clang-format] return ::Compile( cx, options, reinterpret_cast<const char*>(buffer.begin()), buffer.length(), script); | |
| 4092–4094 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& options, const char* bytes, size_t length, JS::MutableHandleScript script) | |
| 4106–4108 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& options, FILE* file, JS::MutableHandleScript script) | |
| 4113–4115 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& options, const char* filename, JS::MutableHandleScript script) | |
| 4120–4122 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& optionsArg, SourceBufferHolder& srcBuf, JS::MutableHandleScript script) | |
| 4129–4131 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& optionsArg, const char* bytes, size_t length, JS::MutableHandleScript script) | |
| 4148–4150 | Warning: Incorrect coding style [clang-format] bool const ReadOnlyCompileOptions& optionsArg, FILE* file, JS::MutableHandleScript script) | |
| 4206–4208 | Warning: Incorrect coding style [clang-format] enum class OffThread Compile, Decode, DecodeBinAST | |
| 4340–4341 | Warning: Incorrect coding style [clang-format] TranscodeSources& sources, OffThreadCompileCallback callback, void* callbackData) | |
| 4421–4423 | Warning: Incorrect coding style [clang-format] RootedScriptSourceObject sourceObject( cx, frontend::CreateScriptSourceObject(cx, options, mozilla::Nothing())); | |
| 4503–4504 | Warning: Incorrect coding style [clang-format] fun.set(NewScriptedFunction(cx,
0,
JSFunction::INTERPRETED_NORMAL, | |
| 4506–4507 | Warning: Incorrect coding style [clang-format] /* proto = */ nullptr, gc::AllocKind::FUNCTION, TenuredObject, | |
| 4575–4577 | Warning: Incorrect coding style [clang-format] const ReadOnlyCompileOptions& options, const char* name, unsigned nargs, const char* const* argnames, SourceBufferHolder& srcBuf, MutableHandleFunction fun) | |
| 4615–4617 | Warning: Incorrect coding style [clang-format] const ReadOnlyCompileOptions& options, const char* name, unsigned nargs, const char* const* argnames, const char16_t* chars, size_t length, MutableHandleFunction fun) | |
| 4728–4730 | Warning: Incorrect coding style [clang-format] MOZ_NEVER_INLINE | |
| 4785–4786 | Warning: Incorrect coding style [clang-format] const ReadOnlyCompileOptions& optionsArg, SourceBufferHolder& srcBuf, MutableHandleValue rval) | |
| 4818–4829 | Warning: Incorrect coding style [clang-format] static bool const ReadOnlyCompileOptions& optionsArg, const char16_t* chars, size_t length, MutableHandleValue rval) { SourceBufferHolder srcBuf(chars, length, SourceBufferHolder::NoOwnership); RootedObject globalLexical(cx, &cx->global()->lexicalEnvironment()); return ::Evaluate(cx, ScopeKind::Global, globalLexical, optionsArg, srcBuf, rval); } extern JS_PUBLIC_API(bool) JS::Evaluate(JSContext* cx, const ReadOnlyCompileOptions& options, const char* bytes, size_t length, MutableHandleValue rval) | |
| 4987–4989 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(void) JS::HandleValue value, uint32_t* lineNumber, uint32_t* columnNumber) | |
| 5164–5165 | Warning: Incorrect coding style [clang-format] UniqueChars stackStr( reinterpret_cast<char*>(BuildUTF8StackString(cx, principals, stack).get())); | |
| 5300–5303 | Warning: Incorrect coding style [clang-format] RootedObject resultPromise(cx);
if (!CallOriginalPromiseThenImpl(cx,
promiseObj,
onResolvedObj,
onRejectedObj,
&resultPromise,
CreateDependentPromise::Always)) { | |
| 5422–5423 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(JSObject*) void* underlyingSource, | |
| 5538–5539 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) JS::HandleObject streamObj, | |
| 5597–5598 | Warning: Incorrect coding style [clang-format] if (stream->mode() != JS::ReadableStreamMode::Default) {
JS_ReportErrorNumberASCII(cx,
GetErrorMessage,
nullptr, | |
| 5615–5616 | Warning: Incorrect coding style [clang-format] if (stream->mode() != JS::ReadableStreamMode::Byte) {
JS_ReportErrorNumberASCII(cx,
GetErrorMessage,
nullptr, | |
| 5628–5629 | Warning: Incorrect coding style [clang-format] } else {
JS_ReportErrorNumberASCII(cx,
GetErrorMessage,
nullptr, | |
| 5756–5758 | Warning: Incorrect coding style [clang-format] cx->asyncCauseForNewActivations = oldAsyncCause; cx->asyncStackForNewActivations() = oldAsyncStack ? &oldAsyncStack->as<SavedFrame>() : nullptr; | |
| 5950–5951 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(const JS::Latin1Char*) const JS::AutoRequireNoGC& nogc, JSString* str, | |
| 5965–5966 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(const char16_t*) const JS::AutoRequireNoGC& nogc, JSString* str, | |
| 6055–6056 | Warning: Incorrect coding style [clang-format] extern JS_PUBLIC_API(const Latin1Char*) JS_GetLatin1FlatStringChars(const JS::AutoRequireNoGC& nogc, JSFlatString* str) | |
| 6273–6275 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) MutableHandleValue vp, HandleObject replacer, HandleValue space, JSONWriteCallback callback, void* data) | |
| 6317–6318 | Warning: Incorrect coding style [clang-format] CHECK_REQUEST(cx); return ParseJSONWithReviver( cx, mozilla::Range<const char16_t>(chars, len), NullHandleValue, vp); | |
| 6346–6348 | Warning: Incorrect coding style [clang-format] return stableChars.isLatin1()
? ParseJSONWithReviver(cx, stableChars.latin1Range(), reviver, vp)
: ParseJSONWithReviver(cx, stableChars.twoByteRange(), reviver, vp); | |
| 6459–6461 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(void) JSErrorCallback errorCallback, void* userRef, const unsigned errorNumber, | |
| 6533–6535 | Warning: Incorrect coding style [clang-format] va_start(ap, errorNumber); ok = ReportErrorNumberVA(cx, flags, errorCallback, userRef, errorNumber, ArgumentsAreLatin1, ap); | |
| 6540–6543 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) unsigned flags, JSErrorCallback errorCallback, void* userRef, const unsigned errorNumber, ...) | |
| 6556–6559 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) unsigned flags, JSErrorCallback errorCallback, void* userRef, const unsigned errorNumber, ...) | |
| 6646–6648 | Warning: Incorrect coding style [clang-format] return RegExpObject::create( cx, chars.get(), length, RegExpFlag(flags), cx->tempLifoAlloc(), GenericObject); | |
| 6722–6724 | Warning: Incorrect coding style [clang-format] return ExecuteRegExpLegacy(cx, nullptr, obj.as<RegExpObject>(), input, indexp, test, rval); | |
| 6934–6935 | Warning: Incorrect coding style [clang-format] void size_t linebufLengthArg, | |
| 6977–6982 | Warning: Incorrect coding style [clang-format] : notes_() { JSErrorNotes::~JSErrorNotes() {} | |
| 6988–6989 | Warning: Incorrect coding style [clang-format] const unsigned errorNumber, ErrorArgumentsType argumentsType, va_list ap) | |
| 7001–7003 | Warning: Incorrect coding style [clang-format] if (!ExpandErrorArgumentsVA(
cx, errorCallback, userRef, errorNumber, nullptr, argumentsType, note.get(), ap)) { | |
| 7053–7056 | Warning: Incorrect coding style [clang-format] JSErrorNotes::addNoteUTF8(JSContext* cx, const char* filename, unsigned lineno, unsigned column, JSErrorCallback errorCallback, void* userRef, const unsigned errorNumber, ...) | |
| 7267–7270 | Warning: Incorrect coding style [clang-format] #ifdef DEBUG case JSJITCOMPILER_FULL_DEBUG_CHECKS:
jit::JitOptions.fullDebugChecks = !!value;
break; | |
| 7283–7311 | Warning: Incorrect coding style [clang-format] switch (opt) {
case JSJITCOMPILER_BASELINE_WARMUP_TRIGGER:
*valueOut = jit::JitOptions.baselineWarmUpThreshold;
break;
case JSJITCOMPILER_ION_WARMUP_TRIGGER:
*valueOut = jit::JitOptions.forcedDefaultIonWarmUpThreshold.valueOr(
jit::OptimizationInfo::CompilerWarmupThreshold);
break;
case JSJITCOMPILER_ION_FORCE_IC:
*valueOut = jit::JitOptions.forceInlineCaches;
break;
case JSJITCOMPILER_ION_CHECK_RANGE_ANALYSIS:
*valueOut = jit::JitOptions.checkRangeAnalysis;
break;
case JSJITCOMPILER_ION_ENABLE:
*valueOut = JS::ContextOptionsRef(cx).ion();
break;
case JSJITCOMPILER_BASELINE_ENABLE:
*valueOut = JS::ContextOptionsRef(cx).baseline();
break;
case JSJITCOMPILER_OFFTHREAD_COMPILATION_ENABLE:
*valueOut = rt->canUseOffthreadIonCompilation();
break;
case JSJITCOMPILER_ASMJS_ATOMICS_ENABLE:
*valueOut = jit::JitOptions.asmJSAtomicsEnable ? 1 : 0;
break;
case JSJITCOMPILER_WASM_FOLD_OFFSETS:
*valueOut = jit::JitOptions.wasmFoldOffsets ? 1 : 0;
break; | |
| 7312–7315 | Warning: Incorrect coding style [clang-format] #ifdef DEBUG case JSJITCOMPILER_FULL_DEBUG_CHECKS:
*valueOut = jit::JitOptions.fullDebugChecks ? 1 : 0;
break; | |
| 7316–7318 | Warning: Incorrect coding style [clang-format] #endif default:
return false; | |
| 7325–7326 | Warning: Incorrect coding style [clang-format] /************************************************************************/ | |
| 7394–7395 | Warning: Incorrect coding style [clang-format] void | |
| 7417–7418 | Warning: Incorrect coding style [clang-format] const char* | |
| 7425–7427 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(bool) | |
| 7629–7630 | Warning: Incorrect coding style [clang-format] JS_PUBLIC_API(JS::TranscodeResult) TranscodeBuffer& buffer, JS::MutableHandleScript scriptp, | |
| 7743–7747 | Warning: Incorrect coding style [clang-format] : JS::FirstSubsumedFrame(cx, cx->realm()->principals(), ignoreSelfHostedFrames) { JS_PUBLIC_API(bool) JS::MutableHandleObject stackp, | |
| toolkit/components/telemetry/gen_event_data.py | ||
| 37 | Error: Line too long (177 > 99 characters) [flake8: E501] | |