Paths

Table of Contentst

Differential D952

Bug 1395119 - Test bug to try phabricator. r?sylvestre
AbandonedPublic
Actions

Authored by andi on Feb 14 2019, 5:39 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Oct 8, 4:26 PM

	Unknown Object (File)
	Thu, Oct 1, 4:22 PM

	Unknown Object (File)
	Jul 20 2026, 3:27 PM

	Unknown Object (File)
	Jul 19 2026, 11:20 PM

	Unknown Object (File)
	Jul 17 2026, 3:35 AM

	Unknown Object (File)
	Jul 12 2026, 1:52 AM

	Unknown Object (File)
	Jun 17 2026, 3:25 AM

	Unknown Object (File)
	Jun 13 2026, 10:29 AM

View All 22 Files

Subscribers

Details

Reviewers

Bugzilla Bug ID

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Branch

default

Build Status

Buildable 1259
Build 2053: Analysis
Build 2052: arc lint + arc unit

Event Timeline

andi created this revision.Feb 14 2019, 5:39 PM

Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2019, 5:39 PM

Harbormaster completed remote builds in B1259: Diff 1549.Feb 14 2019, 5:39 PM

phab-bot requested review of this revision.Feb 14 2019, 5:39 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Code analysis found 1 defect in this patch:

1 defect found by Coverity

If you see a problem in this automated review, please report it here.

toolkit/components/reputationservice/ApplicationReputation.cpp
442	Variable "a" going out of scope leaks the storage it points to. The path that leads to this defect is: toolkit/components/reputationservice/ApplicationReputation.cpp:440: `alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.]`. toolkit/components/reputationservice/ApplicationReputation.cpp:440: `var_assign: Assigning: "a" = storage returned from "new int".`. toolkit/components/reputationservice/ApplicationReputation.cpp:441: `path: Condition "mozilla::detail::log_test(moz_real_module, Debug)", taking true branch.`. toolkit/components/reputationservice/ApplicationReputation.cpp:442: `leaked_storage: Variable "a" going out of scope leaks the storage it points to.`.

Code analysis found 1 defect in this patch:

1 defect found by Coverity

If you see a problem in this automated review, [please report it here](https://bugzilla.mozilla.org/enter_bug.cgi?product=Firefox+Build+System&component=Source+Code+Analysis&short_desc=[Automated+review]+UPDATE&comment=**Phabricator URL:** https://phabricator.services.mozilla.com/...&format=__default__).

toolkit/components/reputationservice/ApplicationReputation.cpp
442	Variable "a" going out of scope leaks the storage it points to. The path that leads to this defect is: toolkit/components/reputationservice/ApplicationReputation.cpp:440: `alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.]`. toolkit/components/reputationservice/ApplicationReputation.cpp:440: `var_assign: Assigning: "a" = storage returned from "new int".`. toolkit/components/reputationservice/ApplicationReputation.cpp:441: `path: Condition "mozilla::detail::log_test(moz_real_module, Debug)", taking true branch.`. toolkit/components/reputationservice/ApplicationReputation.cpp:442: `leaked_storage: Variable "a" going out of scope leaks the storage it points to.`.

Code analysis found 1 defect in this patch:

1 defect found by Coverity

If you see a problem in this automated review, please report it here.

toolkit/components/reputationservice/ApplicationReputation.cpp
442	Variable "a" going out of scope leaks the storage it points to. The path that leads to this defect is: toolkit/components/reputationservice/ApplicationReputation.cpp:440: `alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.]`. toolkit/components/reputationservice/ApplicationReputation.cpp:440: `var_assign: Assigning: "a" = storage returned from "new int".`. toolkit/components/reputationservice/ApplicationReputation.cpp:441: `path: Condition "mozilla::detail::log_test(moz_real_module, Debug)", taking true branch.`. toolkit/components/reputationservice/ApplicationReputation.cpp:442: `leaked_storage: Variable "a" going out of scope leaks the storage it points to.`.

andi abandoned this revision.May 8 2020, 7:21 AM

Herald added a subscriber: phabqareview. · View Herald TranscriptMay 8 2020, 7:21 AM

Revision Contents
Changeset List

Path

Size

2 lines

toolkit/

components/

reputationservice/

ApplicationReputation.cpp

1 line

Diff 1549

.arcconfig

Loading...

toolkit/components/reputationservice/ApplicationReputation.cpp

Loading...