Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Branch
- HEAD
Event Timeline
| .arcconfig | ||
|---|---|---|
| 3 | Test comment | |
Code Review Summarization
Intent
The changes aim to update the Arcanist configuration file (.arcconfig) to point to a new Phabricator instance. This involves migrating from the production Phabricator service (phabricator.services.mozilla.com) to a development/testing environment (phabricator-dev.allizom.org), and updating the repository reference from the Autoland repository to the Mozilla Central repository.
Solution
The solution modifies two configuration values in the .arcconfig file:
- Updates the Phabricator URI to point to the development Allizom domain instead of the production Mozilla services domain
- Changes the repository callsign from "FIREFOXAUTOLAND" to "MOZILLACENTRAL" to reflect the appropriate repository identifier in the new Phabricator instance
These changes ensure that Arcanist commands will interact with the correct Phabricator server and repository when developers use code review tools.
| .arcconfig | ||
|---|---|---|
| 2 | This changes the Phabricator URI to a development instance. The allizom.org domain is Mozilla's development and testing environment, not production. This will redirect all Arcanist code review commands to the dev instance, breaking production workflows. If this is temporary for testing purposes, add a comment with a tracking bug to ensure it doesn't remain in production branches. | |
| js/global.js | ||
|---|---|---|
| 268 ↗ | (On Diff #6378) | event.which is deprecated and removed from web standards. Replace with event.key, which is the modern standard: if (event.altKey && event.key.toLowerCase() === 's') { Using String.fromCharCode(event.which) on a keydown event is also semantically wrong—which returns a key code, not a character code. It happens to work for ASCII letters since the values coincide, but this is fragile and non-standard. |
| .arcconfig | ||
|---|---|---|
| 2–3 | This redirects all moz-phab/arc submissions from the production Phabricator to a dev/staging server. If this lands on a production branch (e.g., autoland, mozilla-central), every developer's patch submissions will go to the wrong server. This should not land unless it is intentionally and temporarily needed for testing, in which case add a comment explaining why and reference a bug tracking the revert. | |
| 3 | The callsign changed from FIREFOXAUTOLAND to MOZILLACENTRAL — these are different repositories. If this branch is autoland, the callsign should remain FIREFOXAUTOLAND. Verify this matches the intended repository on the target Phabricator instance. | |
| .arcconfig | ||
|---|---|---|
| 2–3 | This redirects all arc submissions from the production Phabricator instance to the dev/staging instance. If this lands on autoland, every developer's moz-phab workflow will break — patches will be submitted to phabricator-dev.allizom.org instead of the production server. This change should not be landed unless the intent is a permanent migration, and even then it would need broad coordination. Revert this file if this was only needed for local testing. | |