- patches/0001-clamp-nestegg-uint-reads.patch failed to apply: its context expected the guard 'if (length == 0 || length > 8)' followed immediately by 'r = ne_io_read(io, &b, 1);', but upstream ne_read_uint in src/nestegg.c has been refactored.
- Upstream removed the 'length == 0' term from the guard (it is now 'if (length > 8)') and restructured the body to zero *val and loop with 'while (length--)', so zero-length EBML integers are now accepted and return 0, consistent with RFC 8794 (0..8 octets). ne_read_int likewise now handles length == 0 explicitly.
- The local patch only inserts a documentation comment above the length guard, so its context was retargeted to the new 'if (length > 8)' line; it now applies cleanly (verified via ./mach vendor --patch-mode only).
- Because upstream made a non-trivial behavioral change to the guarded code, and the preserved comment wording ('1..8 bytes wide') is now slightly inconsistent with code that permits zero-length integers, this is reported as uncertain success and a human should confirm the comment wording.
Details
Details
- Reviewers
- None
- Bugzilla Bug ID
- 1855486
Diff Detail
Diff Detail
- Branch
- default
- Build Status
Buildable 5182