diff --git a/differential/customfield/__tests__/DifferentialBugzillaIdCustomFieldTestCase.php b/differential/customfield/__tests__/DifferentialBugzillaIdCustomFieldTestCase.php index d2670d4..7912846 100644 --- a/differential/customfield/__tests__/DifferentialBugzillaIdCustomFieldTestCase.php +++ b/differential/customfield/__tests__/DifferentialBugzillaIdCustomFieldTestCase.php @@ -1,49 +1,52 @@ overrideEnvConfig('bugzilla.require_bugs', true); + $invalids = array(null, '', ' ', '12.3', '1e3'); $field = new DifferentialBugzillaBugIDCommitMessageField(); $field->setViewer(PhabricatorUser::getOmnipotentUser()); foreach ($invalids as $value) { $caught = false; try { $result = $field->validateFieldValue($value); } catch (DifferentialFieldValidationException $ex) { $caught = $ex; } $this->assertTrue( ($caught instanceof DifferentialFieldValidationException)); } } public function testBugIdPropertyViewRendering() { $field = new DifferentialBugzillaBugIDField(); $field->setValue('123'); $this->assertEqual( $field->renderPropertyViewValue(array())->getHTMLContent(), '123' ); } public function testLinkBetweenCommitMessageAndCustomField() { $cm_field = new DifferentialBugzillaBugIDCommitMessageField(); $custom_field = new DifferentialBugzillaBugIDField(); $this->assertEqual( $cm_field->getCustomFieldKey(), $custom_field->getFieldKey() ); $this->assertEqual( $custom_field->getFieldKeyForConduit(), DifferentialBugzillaBugIDCommitMessageField::FIELDKEY ); } }