Page MenuHomePhabricator Dev

phabricator: include bookmark in diff metadata
AbandonedPublic

Authored by Kwan on Oct 10 2019, 9:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:16 AM
Unknown Object (File)
Wed, Oct 7, 5:27 AM
Unknown Object (File)
Aug 4 2026, 6:55 AM
Unknown Object (File)
Aug 4 2026, 6:55 AM
Unknown Object (File)
Jul 24 2026, 5:52 AM
Unknown Object (File)
Jul 22 2026, 7:41 AM
Unknown Object (File)
Jul 15 2026, 12:15 PM
Unknown Object (File)
Jul 15 2026, 11:09 AM
Subscribers

Details

Reviewers
None
Bugzilla Bug ID
Not provided
Summary

While arcanist does this I could see us leaving it out for a couple reasons:

  1. arcanist only operates on the current stack, so can use the actual active bookmark, whereas phabsend works with any commits, so if there are multiple bookmarks it'll just pick the first one arbitrarily
  2. some users might not like the disclosure

Diff Detail

Branch
creatediff (bookmark) on default (branch)
Build Status
Buildable 1955
Build 3201: Analysis

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.