Differential D3243

No bug: Move build environment checks to configure.py. r=phab-email-qa-reviewer-1
Needs ReviewPublic
Actions

Authored by phab-email-qa-author on Jan 11 2022, 4:54 PM.

Tags

None

Referenced Files

	F67105291: D3243.1792437536.diff
	Sun, Oct 18, 7:18 PM

	Unknown Object (File)
	Sun, Oct 11, 10:12 AM

	Unknown Object (File)
	Thu, Sep 24, 1:10 AM

	Unknown Object (File)
	Jul 20 2026, 3:42 PM

	Unknown Object (File)
	Jul 15 2026, 1:53 AM

	Unknown Object (File)
	Jun 28 2026, 8:15 PM

	Unknown Object (File)
	Jun 23 2026, 10:48 PM

	Unknown Object (File)
	Apr 11 2026, 4:09 PM

View All 22 Files

Subscribers

Details

Reviewers

phab-email-qa-reviewer-1

Bugzilla Bug ID

Summary

We also avoid creating the virtualenv before those checks, and remove
the long useless check for build residue in the source directory (these
files will not have been created because builds that would create them
have been forbidden for years)

Depends on D3242

Diff Detail

Repository: rMC m-c
Branch: default

Unit TestsFailed
View All

	Time	Test
	11,689 ms	code-review::mercurial WARNING: The code review bot failed to apply your patch. patching file configure.py Hunk #1 FAILED at 41 1 out of 2 hunks FAILED -- saving rejects to file configure.py.rej abort: patch failed to apply

Event Timeline

phab-email-qa-author created this revision.Jan 11 2022, 4:54 PM

Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 4:54 PM

Harbormaster completed remote builds in B4512: Diff 5174.Jan 11 2022, 4:54 PM

phab-bot published this revision for review.Jan 11 2022, 4:54 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: Restricted Project.

Herald added a subscriber: phabqareview. · View Herald TranscriptJan 11 2022, 4:54 PM

phab-email-qa-author added a child revision: D3244: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Jan 11 2022, 4:54 PM

phab-email-qa-author mentioned this in D3246: No bug: Move build environment checks to configure.py. r?#release-managers! r=phab-email-qa-reviewer-1.Jan 18 2022, 3:09 AM

phab-email-qa-author mentioned this in D3251: No bug: Move build environment checks to configure.py. r?#release-managers! r=phab-email-qa-reviewer-1.Jan 21 2022, 6:09 PM

sheehan changed the repository for this revision from rMC m-c to rVCT vct.Jul 18 2022, 7:28 PM

sheehan added Bugzilla Bug ID 1631233.

sheehan added a child revision: D3360: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Jul 18 2022, 7:29 PM

sheehan removed a child revision: D3360: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Jul 19 2022, 2:45 PM

sheehan added a child revision: D3364: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Jul 19 2022, 3:05 PM

sheehan removed a child revision: D3364: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Jul 19 2022, 3:27 PM

sheehan added a child revision: D3411: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Sep 27 2022, 2:52 AM

sheehan removed a child revision: D3411: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.

sheehan added a child revision: D3414: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Sep 27 2022, 3:10 AM

sheehan removed a child revision: D3414: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.

sheehan added a child revision: D3417: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.Sep 27 2022, 3:24 AM

sheehan removed a child revision: D3417: No bug: s/check_build_environment/build_environment/. r=phab-email-qa-reviewer-1.

No Actions

Showing all changes because you have never taken an action on this revision.

Revision Contents
Changeset List

Path

Size

build/

moz.configure/

85 lines

67 lines

Diff 5174

build/moz.configure/init.configure

Loading...

configure.py

Loading...