Page MenuHomePhabricator Dev

Bug 1631233: second patch r?phab-email-qa-reviewer-2
AcceptedPublic

Authored by sheehan on Jul 26 2022, 12:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:09 AM
Unknown Object (File)
Thu, Sep 24, 1:10 AM
Unknown Object (File)
Aug 5 2026, 6:44 AM
Unknown Object (File)
Jul 29 2026, 6:26 AM
Unknown Object (File)
Jul 22 2026, 6:04 AM
Unknown Object (File)
Jul 2 2026, 1:43 PM
Unknown Object (File)
Jul 1 2026, 5:53 AM
Unknown Object (File)
Jun 27 2026, 6:04 PM
Subscribers

Details

Reviewers
phab-email-qa-author
Group Reviewers
release-managers
Bugzilla Bug ID
1631233
Uplift Request form
  • User impact if declined no impact
  • Code covered by automated testing yes
  • Fix verified in Nightly yes
  • Needs manual QE test no
  • Steps to reproduce for manual QE testing steps here
  • Risk associated with taking this patch no risk
  • Explanation of risk level no risk
  • String changes made/needed no string changes.
  • Is Android affected? no
Summary

test

Depends on D3354

Diff Detail

Repository
rMC m-c
Branch
default

Unit TestsFailed

TimeTest
9,797 mscode-review::mercurial
WARNING: The code review bot failed to apply your patch.
unable to find 'README.md' for patching
(use '--prefix' to apply patch relative to the current directory)
1 out of 1 hunks FAILED -- saving rejects to file README.md.rej
abort: patch failed to apply

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
This revision is now accepted and ready to land.Jul 26 2022, 1:00 AM
grammar added inline comments.
CODE_OF_CONDUCT.md
14

this is a test inline comment

sheehan updated the uplift request field.