Page MenuHomePhabricator Dev

Bug 1855481 - Update nestegg local patches to apply cleanly
Needs ReviewPublic

Authored by update-bot on Jul 7 2026, 8:10 PM.
Tags
None
Referenced Files
F67101588: D4138.1792358665.diff
Sat, Oct 17, 9:24 PM
Unknown Object (File)
Sun, Oct 11, 10:06 AM
Unknown Object (File)
Thu, Oct 1, 6:45 AM
Unknown Object (File)
Thu, Sep 24, 5:27 AM
Unknown Object (File)
Aug 10 2026, 10:19 PM
Unknown Object (File)
Aug 9 2026, 7:40 AM
Unknown Object (File)
Jul 27 2026, 10:12 PM
Unknown Object (File)
Jul 18 2026, 9:18 PM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1855481
Summary

The moz.yaml for media/libnestegg lists a single local patch, patches/0001-clamp-nestegg-uint-reads.patch, a documentation-only patch that adds a comment noting the RFC 8794 EBML unsigned-integer length limit above the length check in ne_read_uint.

The patch failed to apply because upstream refactored ne_read_uint between the version the patch was written against and the current vendored revision (1c9936b171b7e37efce87f7af247c7af0e3ea5b8): the guard changed from if (length == 0 || length > 8) to if (length > 8) (a zero-length unsigned integer is now accepted and decoded as the value 0), and the read logic was restructured from a read-first form into a *val = 0; while (length--) loop.

I re-anchored the patch's single hunk so the comment is inserted above the new if (length > 8) guard. The patch's intent (documenting the length limit) and its location (top of ne_read_uint, above the length check) are unchanged, and it now applies cleanly via ./mach vendor --patch-mode only.

Outcome: uncertain success. The upstream change is non-trivial and touches exactly what the comment documents: the code no longer enforces the lower bound (length != 0), so the comment's "1..8 bytes wide ... enforced" wording now describes only the upper bound the guard still enforces. A human should confirm the comment wording is still appropriate for the new behavior.

Diff Detail

Branch
default
Build Status
Buildable 5179

Event Timeline

phab-bot published this revision for review.Jul 7 2026, 8:10 PM
phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.