Differential D469

Bug 1394994 - refactor revisions.py in the brownbag
Needs ReviewPublic
Actions

Authored by • imadueme2 on Jun 28 2018, 12:55 PM.

Details

Reviewers: None
Bugzilla Bug ID: 1394994

Summary

I made it a lot better boss!

Diff Detail

Repository

rTEST test

Branch

default

Build Status

Buildable 453
Build 528: arc lint + arc unit

Event Timeline

• imadueme2 created this revision.Jun 28 2018, 12:55 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 28 2018, 12:55 PM

• imadueme_admin changed the visibility from "Custom Policy" to "Public (No Login Required)".Jun 28 2018, 12:56 PM

• imadueme_admin changed the edit policy from "Custom Policy" to "All Users".

• imadueme_admin removed a project: Restricted Project.

removing draft state

• imadueme2 requested review of this revision.Jun 28 2018, 12:57 PM

Harbormaster completed remote builds in B452: Diff 719.Jun 28 2018, 12:57 PM

• imadueme_admin added a parent revision: D468: Bug 1394994 - add revisions.py to brownbag.Jun 28 2018, 12:57 PM

• imadueme_admin requested changes to this revision.Jun 28 2018, 1:00 PM

• imadueme_admin added inline comments.

brownbag/revisions.py
21–25	Can we rename this variable to something else?
60–68	This thing will need a new template file...
76	I love this change!

This revision now requires changes to proceed.Jun 28 2018, 1:00 PM

added the template

Harbormaster completed remote builds in B453: Diff 720.Jun 28 2018, 1:02 PM

• imadueme2 marked 3 inline comments as done.Jun 28 2018, 1:03 PM

Awesome!

This revision is now accepted and ready to land.Jun 28 2018, 1:04 PM

dkl removed a reviewer: • imadueme_admin.Jun 28 2018, 2:59 PM

This revision now requires review to proceed.Jun 28 2018, 2:59 PM

phab-bot changed the edit policy from "All Users" to "Restricted Project (Project)".Jun 28 2018, 2:59 PM

Harbormaster completed remote builds in B451: Diff 718.Jun 28 2018, 2:59 PM

Revision Contents
Changeset List

Path

Size

brownbag/

revisions.py

220 lines

template.html

12 lines

Diff 720

View Options

brownbag/revisions.py