Differential D473

Bug 1395000 - add revisions.py to the brownbag thing.
ClosedPublic
Actions

Authored by • imadueme2 on Jul 3 2018, 6:15 PM.

Details

Reviewers

impurelogiq

Commits

rTESTe2366897d554: Bug 1395000 - add revisions.py to the brownbag thing. r=impurelogiq

Bugzilla Bug ID

1395000

Summary

Adds a new file to the brownbag
Wow!

Diff Detail

Repository: rTEST test

Event Timeline

• imadueme2 created this revision.Jul 3 2018, 6:15 PM

Herald added a project: Restricted Project. · View Herald TranscriptJul 3 2018, 6:15 PM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Jul 3 2018, 6:15 PM

phab-bot changed the edit policy from "Custom Policy" to "All Users".

phab-bot removed a project: Restricted Project.

Harbormaster completed remote builds in B457: Diff 726.Jul 3 2018, 6:15 PM

• imadueme2 requested review of this revision.Jul 3 2018, 6:15 PM

• imadueme2 added a child revision: D474: Bug 1395000 - refactor revisions.py in the brownbag.Jul 3 2018, 6:20 PM

Overall I think this is good but there are a few things we need to fix.

brownbag/t3/revisions.py
23	This can be renamed to something else.
52–55	Are you sure this won't crash?
87	I love this function!

This revision now requires changes to proceed.Jul 3 2018, 6:25 PM

fixed the review comment

Harbormaster completed remote builds in B459: Diff 728.Jul 3 2018, 6:28 PM

LGTM

This revision is now accepted and ready to land.Jul 3 2018, 6:28 PM

Closed by commit rTESTe2366897d554: Bug 1395000 - add revisions.py to the brownbag thing. r=impurelogiq (authored by imadueme_bz). · Explain WhyJul 3 2018, 6:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

brownbag/

t3/

revisions.py

246 lines

Diff 729

View Options

Bug 1395000 - add revisions.py to the brownbag thing.ClosedPublicActions