Page MenuHomePhabricator Dev
Differential D704

Bug 1395119 - Test bug to try phabricator. r?sylvestre
AbandonedPublic
Actions

Authored by andi on Oct 3 2018, 10:41 AM.
Tags
None
Referenced Files
F67119773: D704.1792658910.diff
Wed, Oct 21, 8:48 AM
Unknown Object (File)
Thu, Oct 8, 4:24 PM
Unknown Object (File)
Aug 8 2026, 1:08 PM
Unknown Object (File)
Aug 6 2026, 6:55 PM
Unknown Object (File)
Aug 4 2026, 9:38 AM
Unknown Object (File)
Aug 4 2026, 1:54 AM
Unknown Object (File)
Aug 3 2026, 8:37 PM
Unknown Object (File)
Aug 3 2026, 7:46 AM
View All Files
Subscribers
phabqareview
ReviewBot

Details

Reviewers
janx
Bugzilla Bug ID
1395119

Diff Detail

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
ReviewBot added inline comments.Feb 7 2019, 6:18 PM
dom/animation/Animation.cpp
123 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

171 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

ReviewBot added a comment.Feb 8 2019, 2:29 PM

Code analysis found 3 defects in this patch:

  • 3 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

171 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

ReviewBot added a comment.Feb 8 2019, 2:31 PM

Code analysis found 3 defects in this patch:

  • 3 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

171 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

ReviewBot added a comment.Feb 8 2019, 2:37 PM

Code analysis found 3 defects in this patch:

  • 3 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

171 ↗(On Diff #1532)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

andi updated this revision to Diff 1533.Feb 10 2019, 7:43 AM

Revision updated.

Harbormaster completed remote builds in B1243: Diff 1533.Feb 10 2019, 7:43 AM
ReviewBot added a comment.Feb 10 2019, 8:09 AM

Code analysis found 18 defects in this patch:

  • 18 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.

123 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.

171 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

dom/base/nsFrameLoader.cpp
230 ↗(On Diff #1533)
^
241 ↗(On Diff #1533)
^
241 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

241 ↗(On Diff #1533)
^
244 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

248 ↗(On Diff #1533)
^
248 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

248 ↗(On Diff #1533)
^
248 ↗(On Diff #1533)
^
257 ↗(On Diff #1533)
^
257 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

257 ↗(On Diff #1533)
^
276 ↗(On Diff #1533)
^
ReviewBot added a comment.Feb 10 2019, 8:09 AM

Code analysis found 18 defects in this patch:

  • 18 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
171 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.

dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.

dom/base/nsFrameLoader.cpp
230 ↗(On Diff #1533)
^
241 ↗(On Diff #1533)
^
241 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

241 ↗(On Diff #1533)
^
244 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)
^
246 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

248 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

248 ↗(On Diff #1533)
^
257 ↗(On Diff #1533)

'nsGkAtoms::src' declared here

257 ↗(On Diff #1533)
^
257 ↗(On Diff #1533)
^
276 ↗(On Diff #1533)
^
ReviewBot added a comment.Feb 11 2019, 5:34 PM

Code analysis found 18 defects in this patch:

  • 18 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

dom/animation/Animation.cpp:121:

  1. alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.].

dom/animation/Animation.cpp:121:

  1. var_assign: Assigning: "b" = storage returned from "new int"..

dom/animation/Animation.cpp:122:

  1. path: Condition "this->mEffect == aEffect", taking true branch..

dom/animation/Animation.cpp:123:

  1. leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1533)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

dom/animation/Animation.cpp:121:

  1. alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.].

dom/animation/Animation.cpp:121:

  1. var_assign: Assigning: "b" = storage returned from "new int"..

dom/animation/Animation.cpp:122:

  1. path: Condition "this->mEffect == aEffect", taking false branch..

dom/animation/Animation.cpp:129:

  1. path: Condition "this->mEffect.operator bool()", taking true branch..

dom/animation/Animation.cpp:132:

  1. path: Condition "this->mIsRelevant", taking true branch..

dom/animation/Animation.cpp:145:

  1. path: Condition "aEffect", taking true branch..

dom/animation/Animation.cpp:149:

  1. path: Condition "prevAnim", taking true branch..

dom/animation/Animation.cpp:163:

  1. path: Condition "wasRelevant", taking true branch..

dom/animation/Animation.cpp:163:

  1. path: Condition "this->mIsRelevant", taking true branch..

dom/animation/Animation.cpp:171:

  1. leaked_storage: Variable "b" going out of scope leaks the storage it points to..
dom/animation/TimingParams.cpp
184

Variable "a" going out of scope leaks the storage it points to.
The path that leads to this defect is:

dom/animation/TimingParams.cpp:112:

  1. path: Condition "!!!!!!aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:112:

  1. path: Condition "!!!!!!aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:116:

  1. alloc_fn: Storage is returned from allocation function "operator new". [Note: The source code implementation of the function has been overridden by a builtin model.].

dom/animation/TimingParams.cpp:116:

  1. var_assign: Assigning: "a" = storage returned from "new int"..

dom/animation/TimingParams.cpp:121:

  1. path: Condition "aEffectTiming.mDuration.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:124:

  1. path: Condition "aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:129:

  1. path: Condition "aEffectTiming.mIterationStart.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:132:

  1. path: Condition "aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:137:

  1. path: Condition "aEffectTiming.mIterations.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:139:

  1. path: Condition "aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:145:

  1. path: Condition "aEffectTiming.mEasing.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:148:

  1. path: Condition "aRv->Failed()", taking false branch..

dom/animation/TimingParams.cpp:155:

  1. path: Condition "aEffectTiming.mDuration.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:158:

  1. path: Condition "aEffectTiming.mDelay.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:162:

  1. path: Condition "aEffectTiming.mEndDelay.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:166:

  1. path: Condition "aEffectTiming.mIterations.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:169:

  1. path: Condition "aEffectTiming.mIterationStart.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:172:

  1. path: Condition "aEffectTiming.mDirection.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:175:

  1. path: Condition "aEffectTiming.mFill.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:178:

  1. path: Condition "aEffectTiming.mEasing.WasPassed()", taking true branch..

dom/animation/TimingParams.cpp:184:

  1. leaked_storage: Variable "a" going out of scope leaks the storage it points to..
dom/base/nsFrameLoader.cpp
230 ↗(On Diff #1533)

expected ';' at end of declaration
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:230:

  1. err_expected_semi_declaration: expected ';' at end of declaration.

dom/base/nsFrameLoader.cpp:230:

  1. caretline: ^.
241 ↗(On Diff #1533)

no member named 'AssignLiteral' in 'nsStaticAtom'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:241:

  1. err_no_member: no member named 'AssignLiteral' in 'nsStaticAtom'.

dom/base/nsFrameLoader.cpp:241:

  1. caretline: ^.
241 ↗(On Diff #1533)

member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:241:

  1. err_typecheck_member_reference_suggestion: member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?.

dom/base/nsFrameLoader.cpp:241:

  1. caretline: ^.
241 ↗(On Diff #1533)

use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:241:

  1. err_undeclared_var_use_suggest: use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?.

dom/base/nsFrameLoader.cpp:241:

  1. caretline: ^.

obj-x86_64-pc-linux-gnu/dist/include/nsGkAtomList.h:1088:

  1. note_previous_decl: 'nsGkAtoms::src' declared here.
244 ↗(On Diff #1533)

use of undeclared identifier 'src'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:244:

  1. err_undeclared_var_use: use of undeclared identifier 'src'.

dom/base/nsFrameLoader.cpp:244:

  1. caretline: ^.
246 ↗(On Diff #1533)

no member named 'Trim' in 'nsStaticAtom'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:246:

  1. err_no_member: no member named 'Trim' in 'nsStaticAtom'.

dom/base/nsFrameLoader.cpp:246:

  1. caretline: ^.
246 ↗(On Diff #1533)

use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:246:

  1. err_undeclared_var_use_suggest: use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?.

dom/base/nsFrameLoader.cpp:246:

  1. caretline: ^.

obj-x86_64-pc-linux-gnu/dist/include/nsGkAtomList.h:1088:

  1. note_previous_decl: 'nsGkAtoms::src' declared here.
246 ↗(On Diff #1533)

member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:246:

  1. err_typecheck_member_reference_suggestion: member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?.

dom/base/nsFrameLoader.cpp:246:

  1. caretline: ^.
248 ↗(On Diff #1533)

member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:248:

  1. err_typecheck_member_reference_suggestion: member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?.

dom/base/nsFrameLoader.cpp:248:

  1. caretline: ^.
248 ↗(On Diff #1533)

no member named 'IsEmpty' in 'nsStaticAtom'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:248:

  1. err_no_member: no member named 'IsEmpty' in 'nsStaticAtom'.

dom/base/nsFrameLoader.cpp:248:

  1. caretline: ^.
248 ↗(On Diff #1533)

use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:248:

  1. err_undeclared_var_use_suggest: use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?.

dom/base/nsFrameLoader.cpp:248:

  1. caretline: ^.

obj-x86_64-pc-linux-gnu/dist/include/nsGkAtomList.h:1088:

  1. note_previous_decl: 'nsGkAtoms::src' declared here.
257 ↗(On Diff #1533)

member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:257:

  1. err_typecheck_member_reference_suggestion: member reference type 'nsStaticAtom *const' is a pointer; did you mean to use '->'?.

dom/base/nsFrameLoader.cpp:257:

  1. caretline: ^.
257 ↗(On Diff #1533)

use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:257:

  1. err_undeclared_var_use_suggest: use of undeclared identifier 'src'; did you mean 'nsGkAtoms::src'?.

dom/base/nsFrameLoader.cpp:257:

  1. caretline: ^.

obj-x86_64-pc-linux-gnu/dist/include/nsGkAtomList.h:1088:

  1. note_previous_decl: 'nsGkAtoms::src' declared here.
257 ↗(On Diff #1533)

no member named 'AssignLiteral' in 'nsStaticAtom'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:257:

  1. err_no_member: no member named 'AssignLiteral' in 'nsStaticAtom'.

dom/base/nsFrameLoader.cpp:257:

  1. caretline: ^.
276 ↗(On Diff #1533)

use of undeclared identifier 'src'
The path that leads to this defect is:

dom/base/nsFrameLoader.cpp:276:

  1. err_undeclared_var_use: use of undeclared identifier 'src'.

dom/base/nsFrameLoader.cpp:276:

  1. caretline: ^.
andi added a comment.Feb 11 2019, 6:13 PM

Test

coverity error

  • Message: {message}
  • Location: {location}
  • In patch: {in_patch}
  • Coverity check: {check}
  • Publishable : {publishable}
  • Is new: {is_new}
andi added a comment.Feb 11 2019, 6:14 PM
  • 1
  • 2
andi updated this revision to Diff 1534.Feb 12 2019, 8:58 AM

Revision updated.

Harbormaster completed remote builds in B1244: Diff 1534.Feb 12 2019, 8:58 AM
ReviewBot added a comment.Feb 12 2019, 10:06 AM

Code analysis found 2 defects in this patch:

  • 2 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121: alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121: var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122: path: Condition "this->mEffect == aEffect", taking true branch..
  • dom/animation/Animation.cpp:123: leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121: alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121: var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122: path: Condition "this->mEffect == aEffect", taking false branch..
  • dom/animation/Animation.cpp:129: path: Condition "this->mEffect.operator bool()", taking true branch..
  • dom/animation/Animation.cpp:132: path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:145: path: Condition "aEffect", taking true branch..
  • dom/animation/Animation.cpp:149: path: Condition "prevAnim", taking true branch..
  • dom/animation/Animation.cpp:163: path: Condition "wasRelevant", taking true branch..
  • dom/animation/Animation.cpp:163: path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:171: leaked_storage: Variable "b" going out of scope leaks the storage it points to..
andi added a comment.Feb 12 2019, 11:26 AM
This comment was removed by andi.
ReviewBot added a comment.Feb 12 2019, 1:16 PM

Code analysis found 2 defects in this patch:

  • 2 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  1. dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  1. dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  1. dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking true branch..
  1. dom/animation/Animation.cpp:123:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  1. dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  1. dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  1. dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking false branch..
  1. dom/animation/Animation.cpp:129:
    • path: Condition "this->mEffect.operator bool()", taking true branch..
  1. dom/animation/Animation.cpp:132:
    • path: Condition "this->mIsRelevant", taking true branch..
  1. dom/animation/Animation.cpp:145:
    • path: Condition "aEffect", taking true branch..
  1. dom/animation/Animation.cpp:149:
    • path: Condition "prevAnim", taking true branch..
  1. dom/animation/Animation.cpp:163:
    • path: Condition "wasRelevant", taking true branch..
  1. dom/animation/Animation.cpp:163:
    • path: Condition "this->mIsRelevant", taking true branch..
  1. dom/animation/Animation.cpp:171:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
andi added a comment.Feb 12 2019, 3:53 PM
This comment was removed by andi.
ReviewBot added a comment.Feb 12 2019, 5:10 PM

Code analysis found 2 defects in this patch:

  • 2 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking true branch..
  • dom/animation/Animation.cpp:123:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking false branch..
  • dom/animation/Animation.cpp:129:
    • path: Condition "this->mEffect.operator bool()", taking true branch..
  • dom/animation/Animation.cpp:132:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:145:
    • path: Condition "aEffect", taking true branch..
  • dom/animation/Animation.cpp:149:
    • path: Condition "prevAnim", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "wasRelevant", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:171:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
ReviewBot added a comment.Feb 13 2019, 4:10 PM

Code analysis found 2 defects in this patch:

  • 2 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking true branch..
  • dom/animation/Animation.cpp:123:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking false branch..
  • dom/animation/Animation.cpp:129:
    • path: Condition "this->mEffect.operator bool()", taking true branch..
  • dom/animation/Animation.cpp:132:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:145:
    • path: Condition "aEffect", taking true branch..
  • dom/animation/Animation.cpp:149:
    • path: Condition "prevAnim", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "wasRelevant", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:171:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
ReviewBot added a comment.Feb 13 2019, 10:37 PM

Code analysis found 2 defects in this patch:

  • 2 defects found by Coverity

You can run this analysis locally with:

  • Coverity Scan Analysis cannot be ran locally.

If you see a problem in this automated review, please report it here.

dom/animation/Animation.cpp
123 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking true branch..
  • dom/animation/Animation.cpp:123:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
171 ↗(On Diff #1534)

Variable "b" going out of scope leaks the storage it points to.
The path that leads to this defect is:

  • dom/animation/Animation.cpp:121:
    • alloc_fn: Storage is returned from allocation function "operator new"..
  • dom/animation/Animation.cpp:121:
    • var_assign: Assigning: "b" = storage returned from "new int"..
  • dom/animation/Animation.cpp:122:
    • path: Condition "this->mEffect == aEffect", taking false branch..
  • dom/animation/Animation.cpp:129:
    • path: Condition "this->mEffect.operator bool()", taking true branch..
  • dom/animation/Animation.cpp:132:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:145:
    • path: Condition "aEffect", taking true branch..
  • dom/animation/Animation.cpp:149:
    • path: Condition "prevAnim", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "wasRelevant", taking true branch..
  • dom/animation/Animation.cpp:163:
    • path: Condition "this->mIsRelevant", taking true branch..
  • dom/animation/Animation.cpp:171:
    • leaked_storage: Variable "b" going out of scope leaks the storage it points to..
ReviewBot added a comment.Feb 13 2019, 10:37 PM

In our previous code coverage analysis run, we found some files which had no coverage and are being modified in this patch:
.arcconfig
dom/animation/Animation.cpp

Should they have tests, or are they dead code?
You can file a bug blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1415824 for untested files that should be tested.
You can file a bug blocking https://bugzilla.mozilla.org/show_bug.cgi?id=1415819 for untested files that should be removed.

If you see a problem in this automated review, please report it here.

andi abandoned this revision.May 8 2020, 7:20 AM
Herald added a subscriber: phabqareview. · View Herald TranscriptMay 8 2020, 7:20 AM

Revision Contents
Changeset List

PathSize
2 lines
config/
3 lines
dom/
animation/
2 lines
python/
mozbuild/
mozbuild/
2 lines

Diff 1514

View Options

.arcconfig

Loading...
View Options

config/make-system-wrappers.py

Loading...
View Options

dom/animation/TimingParams.cpp

Loading...
View Options

python/mozbuild/mozbuild/util.py

Loading...
Privacy · Cookies · Legal