Page MenuHomePhabricator Dev

Bug 1387052 - Make Firefox code worse intentionally 1/2.
Needs ReviewPublic

Authored by janx on Oct 12 2018, 2:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 4:27 PM
Unknown Object (File)
Jul 25 2026, 11:19 AM
Unknown Object (File)
Jul 20 2026, 2:58 PM
Unknown Object (File)
Jul 20 2026, 5:44 AM
Unknown Object (File)
May 13 2026, 4:19 AM
Unknown Object (File)
May 12 2026, 12:22 AM
Unknown Object (File)
Apr 19 2026, 6:44 PM
Unknown Object (File)
Apr 18 2026, 7:17 AM
Subscribers
None

Details

Reviewers
ReviewBot
Bugzilla Bug ID
1387052

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Oct 12 2018, 2:03 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
janx requested review of this revision.Oct 12 2018, 2:03 PM

Code analysis found 10 defects in this patch:

  • 10 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply): https://queue.taskcluster.net/v1/task/local instance/runs/0/artifacts/public/results/PHID-DIFF-kjel3earj5w2djxluh4v-clang-format.diff

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

dom/media/CubebUtils.cpp
682

Warning: Incorrect coding style [clang-format]

js/ductwork/debugger/JSDebugger.cpp
54–57

Warning: Incorrect coding style [clang-format]

js/src/jsapi.cpp
125–132

Warning: Incorrect coding style [clang-format]

141–143

Warning: Incorrect coding style [clang-format]

195

Warning: Incorrect coding style [clang-format]

227

Warning: Incorrect coding style [clang-format]

233

Warning: Incorrect coding style [clang-format]

235

Warning: Incorrect coding style [clang-format]

248–252

Warning: Incorrect coding style [clang-format]

365

Warning: Incorrect coding style [clang-format]

Code analysis found 21 defects in this patch:

  • 13 defects found by clang-tidy
  • 8 defects found by mozlint

You can run this analysis locally with:

  • ./mach static-analysis check path/to/file.cpp (C/C++)
  • ./mach lint path/to/file (JS/Python/etc)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

browser/base/content/docs/tabbrowser/index.rst
7

Error: Exisits ==> exists [codespell]

devtools/client/definitions.js
7

Error: Infix operators must be spaced. [eslint: space-infix-ops]

devtools/client/menus.js
41

Error: Unexpected tab character. [eslint: no-tabs]

devtools/client/shared/scroll.js
7

Error: Parsing error: Unexpected character '#' [eslint]

dom/media/CubebUtils.cpp
682

Warning: Do not use 'else' after 'return' [clang-tidy: readability-else-after-return]

} else if (aPreferred == CUBEB_DEVICE_PREF_ALL) { // before: readability-else-after-return
  ^~~~~~~~
js/ductwork/debugger/JSDebugger.cpp
50

Warning: Do not use 'else' after 'return' [clang-tidy: readability-else-after-return]

else if (!JS_IsGlobalObject(obj)) { // after: readability-else-after-return
^~~~~~~~
js/src/jsapi.cpp
130

Warning: Suspicious string literal, probably missing a comma [clang-tidy: bugprone-suspicious-missing-comma]

"line 6"     // after: bugprone-suspicious-missing-comma
^
142

Error: Methods annotated with MOZ_NO_DANGLING_ON_TEMPORARIES cannot be && ref-qualified [clang-tidy: mozilla-dangling-on-temporary]

MOZ_NO_DANGLING_ON_TEMPORARIES int *get() && { return nullptr; } // after: mozilla-dangling-on-temporary
                                    ^
143

Error: Methods annotated with MOZ_NO_DANGLING_ON_TEMPORARIES must return a pointer [clang-tidy: mozilla-dangling-on-temporary]

MOZ_NO_DANGLING_ON_TEMPORARIES int test() { return 0; } // after: mozilla-dangling-on-temporary
                                   ^
195

Warning: Do not use 'else' after 'return' [clang-tidy: readability-else-after-return]

else if (ErrorTakesArguments(code_)) { // after: readability-misleading-indentation or readability-else-after-return
^~~~~~~~
227

Warning: Variable 'x' with floating point type 'float' should not be used as a loop counter [clang-tidy: clang-analyzer-security.FloatLoopCounter]

for (float x = 0.1f; x <= 1.0f; x += 0.1f) {} // after: clang-analyzer-security.FloatLoopCounter
^
229

Warning: The return value from the call to 'setuid' is not checked. If an error occurs in 'setuid', the following code may execute with unexpected privileges [clang-tidy: clang-analyzer-security.insecureAPI.UncheckedReturn]

setuid(1); // after: clang-analyzer-security.insecureAPI.UncheckedReturn
^
233

Warning: Statement should be inside braces [clang-tidy: readability-braces-around-statements]

if (x < y); // after: bugprone-suspicious-semicolon; readability-braces-around-statements
          ^
           {
233

Warning: Potentially unintended semicolon [clang-tidy: bugprone-suspicious-semicolon]

if (x < y); // after: bugprone-suspicious-semicolon; readability-braces-around-statements
          ^
251

Warning: Value stored to 'x' is never read [clang-tidy: clang-analyzer-deadcode.DeadStores]

x = 1; // after: clang-analyzer-deadcode.DeadStores
^
356

Warning: 'find' called with a string literal consisting of a single character; consider using the more effective overload accepting a character [clang-tidy: performance-faster-string-find]

str.find("A"); // after: performance-faster-string-find
         ^~~~
         'A'
365

Warning: The type of the loop variable 'p' is different from the one returned by the iterator and generates an implicit conversion; you can either change the type to the matching one ('const std::pair<const int, std::vector<std::cxx11::basic_string<char>, std::allocator<std::cxx11::basic_string<char> > > > &' but 'const auto&' is always a valid option) or remove the reference to make it explicit that you are creating a new value [clang-tidy: performance-implicit-conversion-in-loop]

for (const std::pair<int, std::vector<std::string>>& p : my_map) {} // after: performance-implicit-conversion-in-loop
     ^
toolkit/components/telemetry/build_scripts/gen_event_data.py
41

Error: Line too long (177 > 99 characters) [flake8: E501]

41

Error: At least two spaces before inline comment [flake8: E261]

41

Error: Missing whitespace around operator [flake8: E225]

65

Error: Continuation line under-indented for visual indent [flake8: E128]

Code analysis found 10 defects in this patch:

  • 10 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects: https://queue.taskcluster.net/v1/task/local instance/runs/0/artifacts/public/results/PHID-DIFF-kjel3earj5w2djxluh4v-clang-format.diff (use it in your repository with hg import or git apply)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

dom/media/CubebUtils.cpp
682

Warning: Incorrect coding style [clang-format]

js/ductwork/debugger/JSDebugger.cpp
54–57

Warning: Incorrect coding style [clang-format]

js/src/jsapi.cpp
125–132

Warning: Incorrect coding style [clang-format]

141–143

Warning: Incorrect coding style [clang-format]

195

Warning: Incorrect coding style [clang-format]

227

Warning: Incorrect coding style [clang-format]

233

Warning: Incorrect coding style [clang-format]

235

Warning: Incorrect coding style [clang-format]

248–252

Warning: Incorrect coding style [clang-format]

365

Warning: Incorrect coding style [clang-format]