Page MenuHomePhabricator Dev

Bug 1395172 - Patch8
Needs ReviewPublic

Authored by zalun on Dec 13 2018, 3:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 4:26 PM
Unknown Object (File)
Aug 8 2026, 1:40 PM
Unknown Object (File)
Aug 4 2026, 10:03 PM
Unknown Object (File)
Jul 24 2026, 7:44 AM
Unknown Object (File)
Jul 16 2026, 2:26 AM
Unknown Object (File)
Jul 15 2026, 7:02 PM
Unknown Object (File)
Jun 13 2026, 4:12 AM
Unknown Object (File)
Jun 9 2026, 7:10 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1395172
Summary

Depends on D877

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 13 2018, 3:41 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
zalun requested review of this revision.Dec 13 2018, 3:41 PM

Code analysis found 7 defects in this patch:

  • 7 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects: https://queue.taskcluster.net/v1/task/DbGd7E-GTc2JUZogIwwSOg/runs/0/artifacts/public/results/clang-format-PHID-DIFF-wvmpswgz3i6tas262gyp.diff (use it in your repository with hg import or git apply)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

widget/gtk/nsClipboard.cpp
167

Warning: Incorrect coding style [clang-format]

169–170

Warning: Incorrect coding style [clang-format]

174–180

Warning: Incorrect coding style [clang-format]

480–486

Warning: Incorrect coding style [clang-format]

488–491

Warning: Incorrect coding style [clang-format]

493–495

Warning: Incorrect coding style [clang-format]

497–499

Warning: Incorrect coding style [clang-format]