Page MenuHomePhabricator Dev

Bug 1395172 - PATCH9
Needs ReviewPublic

Authored by zalun on Dec 17 2018, 9:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 4:22 PM
Unknown Object (File)
Aug 3 2026, 1:59 AM
Unknown Object (File)
Jul 22 2026, 12:20 PM
Unknown Object (File)
Jul 21 2026, 6:55 PM
Unknown Object (File)
Jul 16 2026, 10:09 AM
Unknown Object (File)
May 4 2026, 10:37 AM
Unknown Object (File)
May 3 2026, 3:49 AM
Unknown Object (File)
Apr 13 2026, 6:39 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1395172
Summary

Depends on D895

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

Code analysis found 3 defects in this patch:

  • 2 defects found by clang-format
  • 1 defect found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)
  • ./mach static-analysis check path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply).

If you see a problem in this automated review, please report it here.

js/src/vm/Interpreter.cpp
1635

Warning: Macro argument should be enclosed in parentheses [clang-tidy: bugprone-macro-parentheses]

obj = ToObjectFromStack((cx), (val));                                 \
^~~
()

Code analysis found 3 defects in this patch:

  • 2 defects found by clang-format
  • 1 defect found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)
  • ./mach static-analysis check path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply).

If you see a problem in this automated review, please report it here.

js/src/vm/Interpreter.cpp
1635

Warning: Macro argument should be enclosed in parentheses [clang-tidy: bugprone-macro-parentheses]

obj = ToObjectFromStack((cx), (val));                                 \
^~~
()