Page MenuHomePhabricator Dev

Bug 1395172 - Patch10
Needs ReviewPublic

Authored by zalun on Dec 13 2018, 3:43 PM.
Tags
None
Referenced Files
F67102438: D880.1792406404.diff
Sun, Oct 18, 10:40 AM
Unknown Object (File)
Thu, Oct 8, 4:24 PM
Unknown Object (File)
Aug 3 2026, 5:47 AM
Unknown Object (File)
Jul 24 2026, 4:35 AM
Unknown Object (File)
Jul 23 2026, 11:27 PM
Unknown Object (File)
Jul 22 2026, 10:00 AM
Unknown Object (File)
Jul 7 2026, 3:00 AM
Unknown Object (File)
Jun 30 2026, 3:26 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1395172
Summary

Depends on D879

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 13 2018, 3:43 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
zalun requested review of this revision.Dec 13 2018, 3:43 PM

Code analysis found 2 defects in this patch:

  • 2 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects: https://queue.taskcluster.net/v1/task/eu2Zb_FfT3GfpAscUq8GcQ/runs/0/artifacts/public/results/clang-format-PHID-DIFF-iubed6qtmltccp62yo3o.diff (use it in your repository with hg import or git apply)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

toolkit/crashreporter/nsExceptionHandler.cpp
893

Warning: Incorrect coding style [clang-format]

895

Warning: Incorrect coding style [clang-format]