Page MenuHomePhabricator Dev

Prova 2
Needs ReviewPublic

Authored by marco on Oct 12 2020, 9:11 AM.
Tags
None
Referenced Files
F67101917: D3003.1792379365.diff
Sun, Oct 18, 3:09 AM
F67101916: D3003.1792379290.diff
Sun, Oct 18, 3:08 AM
F67101915: D3003.1792379289.diff
Sun, Oct 18, 3:08 AM
Unknown Object (File)
Sun, Oct 11, 10:04 AM
Unknown Object (File)
Fri, Oct 9, 9:49 PM
Unknown Object (File)
Thu, Oct 1, 6:45 AM
Unknown Object (File)
Thu, Sep 24, 1:14 AM
Unknown Object (File)
Jul 26 2026, 6:41 AM
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
Not provided

Diff Detail

Unit TestsFailed

TimeTest
16,188 mscode-review::mercurial
WARNING: The code review bot failed to apply your patch.
patching file taskcluster/ci/fetch/toolchains.yml
Hunk #1 FAILED at 435
1 out of 1 hunks FAILED -- saving rejects to file taskcluster/ci/fetch/toolchains.yml.rej
abort: patch failed to apply

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

Code analysis found 5 defects in the diff 4716:

  • 1 defect found by clang-format
  • 4 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -s -p dom/fetch/FetchStreamReader.cpp (C/C++)
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 5 defects in the diff 4717:

  • 1 defect found by clang-format
  • 4 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -s -p dom/fetch/FetchStreamReader.cpp (C/C++)
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-clang-external failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

This comment was removed by freddy.
This comment was removed by freddy.
This comment was removed by freddy.
This comment was removed by freddy.
This comment was removed by freddy.
This comment was removed by freddy.

Code analysis found 5 defects in the diff 4717:

  • 1 defect found by clang-format
  • 4 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -s -p dom/fetch/FetchStreamReader.cpp (C/C++)
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-clang-external failed, but we could not detect any issue.
Please check this task manually.

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.