Page MenuHomePhabricator Dev

code-review-bot (Code Review Bot)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Apr 2 2019, 6:01 PM (393 w, 4 d)
Availability
Available
Review Queue
1

Recent Activity

Mar 5 2025

code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.

Code analysis found 1 defect in diff 5933:

  • 1 defect found by py-black (Mozlint)
Mar 5 2025, 8:40 AM

Mar 4 2025

code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.

Code analysis found 1 defect in diff 5932:

  • 1 defect found by py-black (Mozlint)
Mar 4 2025, 11:48 AM

Mar 3 2025

code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.

Code analysis found 1 defect in diff 5932:

  • 1 defect found by py-black (Mozlint)
Mar 3 2025, 4:29 PM

Feb 28 2025

code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.

Code analysis found 1 defect in diff 5931:

  • 1 defect found by py-black (Mozlint)
Feb 28 2025, 10:31 AM

Feb 26 2025

code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.

Code analysis found 1 defect in diff 5908:

  • 1 defect found by py-black (Mozlint)
Feb 26 2025, 11:31 AM
code-review-bot added a comment to D3735: Bug XYZ - Bad patch to trigger code review.
Feb 26 2025, 10:52 AM

May 11 2023

code-review-bot added a comment to D3533: Test new changes to code-review part 10.

Code analysis found 11 defects in diff 5598:

  • 11 defects found by eslint (Mozlint)
May 11 2023, 9:00 AM
code-review-bot added a comment to D3532: WIP: Bug XX4 - Test before/after feature.

Code analysis found 237 defects in diff 5597:

  • 237 defects found by eslint (Mozlint)
May 11 2023, 8:01 AM

May 10 2023

code-review-bot added a comment to D3531: WIP: Bug XX3: Test code review before/after feature.

Code analysis found 690 defects in diff 5596:

  • 690 defects found by eslint (Mozlint)
May 10 2023, 8:08 AM

May 9 2023

code-review-bot added a comment to D3527: WIP: Bug XXX: Test code review before/after feature.

Code analysis found 690 defects in diff 5592:

  • 690 defects found by eslint (Mozlint)
May 9 2023, 3:51 PM

Feb 10 2023

code-review-bot added a comment to D3459: Bug 1630534 - another code revewi int test..

Code analysis found 1 defect in the diff 5510:

  • 1 defect found by py-isort (Mozlint)
Feb 10 2023, 5:37 PM

Jan 24 2023

code-review-bot added a comment to D3459: Bug 1630534 - another code revewi int test..

Code analysis found 1 defect in the diff 5490:

  • 1 defect found by py-isort (Mozlint)
Jan 24 2023, 10:16 AM

Jan 12 2023

code-review-bot added a comment to D3197: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-format failed, but we could not detect any issue.
Please check this task manually.

Jan 12 2023, 3:12 PM

Oct 8 2021

code-review-bot added a comment to D3198: Bug 1630534 - Code review integration test for C++..

Code analysis found 8 defects in the diff 5125:

  • 1 defect found by clang-format
  • 1 defect found by file-whitespace (Mozlint)
  • 3 defects found by Coverity
  • 3 defects found by clang-tidy
Oct 8 2021, 2:35 PM

Oct 5 2021

code-review-bot added a comment to D3198: Bug 1630534 - Code review integration test for C++..

Code analysis found 5 defects in the diff 5119:

  • 1 defect found by clang-format
  • 1 defect found by file-whitespace (Mozlint)
  • 3 defects found by clang-tidy
Oct 5 2021, 10:33 AM

Sep 14 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:31 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:29 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:26 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:24 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:23 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:21 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 14 2021, 2:18 PM

Sep 12 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5103:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 2:00 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5102:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 1:07 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5101:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 12:20 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5100:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 11:45 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5099:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 10:47 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 12 2021, 10:01 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 12 2021, 10:00 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 12 2021, 9:59 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 12 2021, 9:57 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5098:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 12 2021, 9:50 AM

Sep 11 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5097:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 4:18 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:38 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:37 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:36 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:33 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:32 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:31 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:29 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:26 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:25 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:23 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:22 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:20 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:20 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:18 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:17 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 3:16 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5096:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 3:13 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:28 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:25 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:23 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:20 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:19 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:18 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Sep 11 2021, 2:16 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5095:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 2:04 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5094:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 12:40 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5092:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 12:27 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5093:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 12:27 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5091:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 11:46 AM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5090:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 11 2021, 11:30 AM

Sep 7 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 7 defects in the diff 5084:

  • 1 build error and 2 defects found by clang-tidy
  • 1 defect found by clang-format
  • 3 defects found by Coverity
Sep 7 2021, 2:54 PM

Jul 19 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 2 defects in the diff 5068:

  • 1 build error and 1 defect found by clang-tidy
Jul 19 2021, 1:00 PM

Jul 16 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 2 defects in the diff 5067:

  • 1 build error and 1 defect found by clang-tidy
Jul 16 2021, 3:52 PM

Jul 14 2021

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 3 defects in the diff 5061:

  • 1 build error and 1 defect found by clang-tidy
  • 1 defect found by Coverity
Jul 14 2021, 12:30 PM

Feb 12 2021

code-review-bot added a comment to D3072: (dev) testing one two check check mic one tow check.

Code analysis found 1 defect in the diff 4827:

  • 1 defect found by private static analysis
Feb 12 2021, 10:54 AM

Feb 3 2021

code-review-bot added a comment to D3065: random linter fail, maybe.

Code analysis found 2 defects in the diff 4819:

  • 1 defect found by clang-format
  • 1 defect found by clang-tidy
Feb 3 2021, 2:35 PM
code-review-bot added a comment to D3064: add stupid function that might cause static analysis error.

Code analysis found 1 defect in the diff 4818:

  • 1 defect found by clang-format
Feb 3 2021, 2:08 PM

Nov 20 2020

code-review-bot added a comment to D3032: Bug 1629843 - Update dav1d to ba875b9649f2c74a88da489cf11df53d27247936.

You have touched the documentation, you can find it rendered here for a week.

Nov 20 2020, 7:43 PM

Nov 18 2020

code-review-bot added a comment to D3031: Bug 1629838 - Update dav1d to 3fdf468e51307c3fefabb65dfc39f364edd2ae95.

The analysis task source-test-clang-external failed, but we could not detect any issue.
Please check this task manually.

Nov 18 2020, 10:53 PM
code-review-bot added a comment to D3030: Bug 1629837 - Update dav1d to 3fdf468e51307c3fefabb65dfc39f364edd2ae95.

The analysis task source-test-clang-external failed, but we could not detect any issue.
Please check this task manually.

Nov 18 2020, 5:41 PM

Nov 12 2020

code-review-bot added a comment to D3027: most exquisite testing on a cold November Thursday evening.

Code analysis found 5 defects in the diff 4749:

  • 1 defect found by clang-format
  • 1 defect found by private static analysis
  • 3 defects found by clang-tidy
Nov 12 2020, 6:09 PM

Nov 11 2020

code-review-bot added a comment to D3026: testy test - wed 4:30pm.

Code analysis found 4 defects in the diff 4748:

  • 1 defect found by clang-format
  • 3 defects found by clang-tidy
Nov 11 2020, 3:55 PM

Nov 10 2020

code-review-bot added a comment to D3023: test - tuesday 1:30pm.

Code analysis found 1 defect in the diff 4745:

  • 1 defect found by clang-format
Nov 10 2020, 3:39 PM
code-review-bot added a comment to D3022: not disabled this time -- test trigger civet warning - 2020-11-09.

Code analysis found 2 defects in the diff 4744:

  • 1 build error found by clang-tidy
  • 1 defect found by clang-format
Nov 10 2020, 3:24 PM
code-review-bot added a comment to D3021: test trigger civet warning - 2020-11-09.

Code analysis found 2 defects in the diff 4743:

  • 1 build error found by clang-tidy
  • 1 defect found by clang-format
Nov 10 2020, 3:21 PM
code-review-bot added a comment to D3021: test trigger civet warning - 2020-11-09.

Code analysis found 2 defects in the diff 4741:

  • 1 build error found by clang-tidy
  • 1 defect found by clang-format
Nov 10 2020, 3:20 PM
code-review-bot added a comment to D3021: test trigger civet warning - 2020-11-09.

Code analysis found 2 defects in the diff 4742:

  • 1 build error found by clang-tidy
  • 1 defect found by clang-format
Nov 10 2020, 3:20 PM

Oct 12 2020

code-review-bot added a comment to D3003: Prova 2.

Code analysis found 5 defects in the diff 4717:

  • 1 defect found by clang-format
  • 4 defects found by clang-tidy
Oct 12 2020, 2:21 PM
code-review-bot added a comment to D3003: Prova 2.

Code analysis found 5 defects in the diff 4716:

  • 1 defect found by clang-format
  • 4 defects found by clang-tidy
Oct 12 2020, 1:29 PM

Sep 24 2020

code-review-bot added a comment to D2980: Bug 1629558 - Update dav1d to f90ada0d08e99ccfb676e59b8e3c497e77879915.

You have touched the documentation, you can find it rendered here for a week.

Sep 24 2020, 9:23 PM
code-review-bot added a comment to D2978: Bug 1629557 - Update dav1d to f90ada0d08e99ccfb676e59b8e3c497e77879915.

You have touched the documentation, you can find it rendered here for a week.

Sep 24 2020, 7:59 PM

Sep 21 2020

code-review-bot added a comment to D2977: Bug 1629541 - Update dav1d to f90ada0d08e99ccfb676e59b8e3c497e77879915.

You have touched the documentation, you can find it rendered here for a week.

Sep 21 2020, 11:37 PM

Sep 16 2020

code-review-bot added a comment to D2972: Bug 1629332 - Update dav1d to 8c2a89768692b0b1a7f9a1a0985d99319bd2918d.

You have touched the documentation, you can find it rendered here for a week.

Sep 16 2020, 2:36 AM

Sep 11 2020

code-review-bot added a comment to D2967: no bug - Doc: document `vscode` integration. r=sylvestre.

You have touched the documentation, you can find it rendered here for a week.

Sep 11 2020, 3:01 PM
code-review-bot added a comment to D2967: no bug - Doc: document `vscode` integration. r=sylvestre.

You have touched the documentation, you can find it rendered here for a week.

Sep 11 2020, 2:35 PM

Sep 10 2020

code-review-bot added a comment to D2967: no bug - Doc: document `vscode` integration. r=sylvestre.

You have touched the documentation, you can find it rendered here for a week.

Sep 10 2020, 2:54 PM

Aug 1 2020

code-review-bot added a comment to D2947: Bug 1629124 - Update dav1d to 6cf58c8e7deb54e287afeee6710b2a3774eded9c.

The analysis task source-test-clang-tidy failed, but we could not detect any issue.
Please check this task manually.

Aug 1 2020, 6:04 AM

Jul 31 2020

code-review-bot added a comment to D2946: Bug 1629123 - Update dav1d to 6cf58c8e7deb54e287afeee6710b2a3774eded9c.

The analysis task source-test-clang-format failed, but we could not detect any issue.
Please check this task manually.

Jul 31 2020, 8:29 PM
code-review-bot added a comment to D2945: Bug 1629122 - Update dav1d to 6cf58c8e7deb54e287afeee6710b2a3774eded9c.

The analysis task source-test-doc-upload failed, but we could not detect any issue.
Please check this task manually.

Jul 31 2020, 7:31 PM

Jul 27 2020

code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 3 defects in the diff 4567:

  • 1 defect found by clang-tidy
  • 2 defects found by Coverity
Jul 27 2020, 6:03 PM
code-review-bot added a comment to D1813: Bug 1630534 - Code review integration test.

Code analysis found 3 defects in the diff 4566:

  • 1 defect found by clang-tidy
  • 2 defects found by Coverity
Jul 27 2020, 1:34 PM

Jul 24 2020

code-review-bot added a comment to D2936: test commit, copied from D76139 partially.

Code analysis found 102 defects in the diff 4550:

  • 102 build errors found by clang-tidy
Jul 24 2020, 12:29 PM

May 19 2020

code-review-bot added a comment to D1840: broken rev.

Code analysis found 3 defects in the diff 3064:

  • 1 build error found by Coverity
  • 2 defects found by clang-tidy
May 19 2020, 7:10 AM

May 18 2020

code-review-bot added a comment to D1839: broken rev.

Code analysis found 4 defects in the diff 3063:

  • 2 build errors and 2 defects found by clang-tidy
May 18 2020, 6:16 PM

Apr 16 2020

code-review-bot added a comment to D1758: Bug XXYYZZ - Really bad patch to trigger lots of issues, r=marco.

Code analysis found 9 defects in the diff 2934:

  • 1 build error found by Coverity
  • 1 defect found by clang-tidy
  • 1 defect found by code coverage analysis
  • 1 defect found by license (Mozlint)
  • 2 defects found by eslint (Mozlint)
  • 3 defects found by clang-format
Apr 16 2020, 9:36 AM

Apr 15 2020

code-review-bot added a comment to D1758: Bug XXYYZZ - Really bad patch to trigger lots of issues, r=marco.

Code analysis found 9 defects in the diff 2934:

  • 1 build error found by Coverity
  • 1 defect found by clang-tidy
  • 1 defect found by code coverage analysis
  • 1 defect found by license (Mozlint)
  • 2 defects found by eslint (Mozlint)
  • 3 defects found by clang-format
Apr 15 2020, 11:39 AM
code-review-bot added a comment to D1758: Bug XXYYZZ - Really bad patch to trigger lots of issues, r=marco.

Code analysis found 9 defects in the diff 2934:

  • 1 build error found by Coverity
  • 1 defect found by clang-tidy
  • 1 defect found by code coverage analysis
  • 1 defect found by license (Mozlint)
  • 2 defects found by eslint (Mozlint)
  • 3 defects found by clang-format
Apr 15 2020, 8:22 AM