Page MenuHomePhabricator Dev

most exquisite testing on a cold November Thursday evening
Needs ReviewPublic

Authored by freddy on Nov 12 2020, 5:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 11, 10:03 AM
Unknown Object (File)
Thu, Sep 24, 5:24 AM
Unknown Object (File)
Aug 7 2026, 2:43 AM
Unknown Object (File)
Aug 4 2026, 9:22 AM
Unknown Object (File)
Jun 30 2026, 7:37 AM
Unknown Object (File)
Jun 30 2026, 1:33 AM
Unknown Object (File)
Jun 29 2026, 1:48 AM
Unknown Object (File)
Jun 19 2026, 9:42 AM
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
Not provided

Diff Detail

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.

Code analysis found 5 defects in the diff 4749:

  • 1 defect found by clang-format
  • 1 defect found by private static analysis
  • 3 defects found by clang-tidy

You can run this analysis locally with:

  • For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
  • ./mach clang-format -s -p dom/fetch/FetchStreamReader.cpp (C/C++)
  • ./mach static-analysis check --outgoing (C/C++)
Private Static Analysis warning
  • Message: binary search algorithm is prone to integer overflows
  • Location: dom/fetch/FetchStreamReader.cpp:52:14
  • Clang check: mozilla-civet-binary-search-overflow-checker
  • in an expanded Macro: no

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.