Details
Details
- Reviewers
- None
- Bugzilla Bug ID
- Not provided
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
Event Timeline
Comment Actions
Code analysis found 5 defects in the diff 4749:
- 1 defect found by clang-format
- 1 defect found by private static analysis
- 3 defects found by clang-tidy
You can run this analysis locally with:
- For private static analysis, please see our private docs in Mana, if you cannot access this resource, ask your reviewer to help you resolve the issue.
- ./mach clang-format -s -p dom/fetch/FetchStreamReader.cpp (C/C++)
- ./mach static-analysis check --outgoing (C/C++)
Private Static Analysis warning
- Message: binary search algorithm is prone to integer overflows
- Location: dom/fetch/FetchStreamReader.cpp:52:14
- Clang check: mozilla-civet-binary-search-overflow-checker
- in an expanded Macro: no
For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).
If you see a problem in this automated review, please report it here.
You can view these defects on the code-review frontend and on Treeherder.