Page MenuHomePhabricator Dev

Bug 1394994 - refactor revisions.py in the brownbag
Needs ReviewPublic

Authored by • imadueme2 on Jun 28 2018, 12:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 4:26 PM
Unknown Object (File)
Aug 4 2026, 5:23 AM
Unknown Object (File)
Jul 23 2026, 8:47 PM
Unknown Object (File)
Jul 22 2026, 2:42 AM
Unknown Object (File)
Jul 22 2026, 2:24 AM
Unknown Object (File)
Jul 22 2026, 1:51 AM
Unknown Object (File)
Jul 15 2026, 4:32 PM
Unknown Object (File)
Jun 27 2026, 5:17 AM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1394994
Summary

I made it a lot better boss!

Diff Detail

Repository
rTEST test
Branch
default

Event Timeline

• imadueme_admin changed the visibility from "Custom Policy" to "Public (No Login Required)".Jun 28 2018, 12:56 PM
• imadueme_admin changed the edit policy from "Custom Policy" to "All Users".
• imadueme_admin removed a project: Restricted Project.
• imadueme_admin added inline comments.
brownbag/revisions.py
21–25

Can we rename this variable to something else?

60–68

This thing will need a new template file...

76

I love this change!

This revision now requires changes to proceed.Jun 28 2018, 1:00 PM
This revision is now accepted and ready to land.Jun 28 2018, 1:04 PM
This revision now requires review to proceed.Jun 28 2018, 2:59 PM
phab-bot changed the edit policy from "All Users" to "Restricted Project (Project)".Jun 28 2018, 2:59 PM