Page MenuHomePhabricator Dev

Bug 1395172 - Patch3
Needs ReviewPublic

Authored by zalun on Dec 13 2018, 3:37 PM.
Tags
None
Referenced Files
F67105175: D873.1792431649.diff
Sun, Oct 18, 5:40 PM
Unknown Object (File)
Thu, Oct 8, 4:24 PM
Unknown Object (File)
Aug 8 2026, 10:52 PM
Unknown Object (File)
Aug 2 2026, 7:54 PM
Unknown Object (File)
Jul 24 2026, 4:20 PM
Unknown Object (File)
Jul 22 2026, 9:56 AM
Unknown Object (File)
Jul 16 2026, 3:19 PM
Unknown Object (File)
Jun 7 2026, 4:30 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1395172
Summary

Depends on D872

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 13 2018, 3:37 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
zalun requested review of this revision.Dec 13 2018, 3:37 PM

Code analysis found 1 defect in this patch:

  • 1 defect found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects: https://queue.taskcluster.net/v1/task/JwtcpAN3SEq_AuFWRFA-WQ/runs/0/artifacts/public/results/clang-format-PHID-DIFF-7e6cumbt73k73rpr2wjs.diff (use it in your repository with hg import or git apply)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

dom/cache/TypeUtils.cpp
527

Warning: Incorrect coding style [clang-format]