Page MenuHomePhabricator Dev

Bug 1395172 - Patch6
Needs ReviewPublic

Authored by zalun on Dec 13 2018, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 4:22 PM
Unknown Object (File)
Jul 25 2026, 6:06 PM
Unknown Object (File)
Jul 23 2026, 10:30 PM
Unknown Object (File)
Jul 22 2026, 7:52 AM
Unknown Object (File)
Jul 12 2026, 1:37 PM
Unknown Object (File)
Jul 8 2026, 5:40 PM
Unknown Object (File)
Jun 13 2026, 9:13 AM
Unknown Object (File)
Jun 9 2026, 9:45 AM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Bugzilla Bug ID
1395172
Summary

Depends on D875

Diff Detail

Repository
rMOZILLACENTRAL mozilla-central
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".Dec 13 2018, 3:40 PM
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
zalun requested review of this revision.Dec 13 2018, 3:40 PM

Code analysis found 6 defects in this patch:

  • 6 defects found by clang-format

You can run this analysis locally with:

  • ./mach clang-format -p path/to/file.cpp (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects: https://queue.taskcluster.net/v1/task/TyR0f8DIQYynVLpWysjAXg/runs/0/artifacts/public/results/clang-format-PHID-DIFF-ffky5vkofjc657ba4hzn.diff (use it in your repository with hg import or git apply)

If you see a problem in this automated review, please report it here: https://bit.ly/2IyNRy2

toolkit/components/perfmonitoring/PerformanceMetricsCollector.cpp
33

Warning: Incorrect coding style [clang-format]

46–48

Warning: Incorrect coding style [clang-format]

52–55

Warning: Incorrect coding style [clang-format]

76

Warning: Incorrect coding style [clang-format]

294

Warning: Incorrect coding style [clang-format]

toolkit/components/perfmonitoring/PerformanceMetricsCollector.h
24

Warning: Incorrect coding style [clang-format]