Page MenuHomePhabricator Dev

Bug 1630534 - Code review integration test for C++.
AbandonedPublic

Authored by andi on Sep 15 2021, 1:41 PM.
Tags
None
Referenced Files
F67102178: D3198.1792394050.diff
Sun, Oct 18, 7:14 AM
Unknown Object (File)
Sun, Oct 11, 10:15 AM
Unknown Object (File)
Fri, Oct 9, 1:01 PM
Unknown Object (File)
Fri, Oct 9, 12:59 PM
Unknown Object (File)
Thu, Oct 1, 6:47 AM
Unknown Object (File)
Thu, Oct 1, 6:46 AM
Unknown Object (File)
Thu, Oct 1, 6:45 AM
Unknown Object (File)
Thu, Oct 1, 6:44 AM
Subscribers

Details

Reviewers
None
Bugzilla Bug ID
1630534

Diff Detail

Repository
rMC m-c
Branch
default

Event Timeline

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".
phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".
phab-bot removed a project: Restricted Project.
andi retitled this revision from Bug 1630534 - Code review integration test to Bug 1630534 - Code review integration test for C++.

Code analysis found 5 defects in the diff 5119:

  • 1 defect found by clang-format
  • 1 defect found by file-whitespace (Mozlint)
  • 3 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -p dom/animation/Animation.cpp
  • ./mach lint --warnings --outgoing
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).

The analysis task source-test-coverity-coverity failed, but we could not detect any issue.
Please check this task manually.


If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

Code analysis found 8 defects in the diff 5125:

  • 1 defect found by clang-format
  • 1 defect found by file-whitespace (Mozlint)
  • 3 defects found by Coverity
  • 3 defects found by clang-tidy

You can run this analysis locally with:

  • ./mach clang-format -p dom/animation/Animation.cpp
  • ./mach lint --warnings --outgoing
  • ./mach static-analysis check --outgoing (C/C++)

For your convenience, here is a patch that fixes all the clang-format defects (use it in your repository with hg import or git apply -p0).


If you see a problem in this automated review, please report it here.

You can view these defects on the code-review frontend and on Treeherder.

andi retitled this revision from Bug 1630534 - Code review integration test for C++ to Bug 1630534 - Code review integration test for C++ ..
andi retitled this revision from Bug 1630534 - Code review integration test for C++ . to Bug 1630534 - Code review integration test for C++..
andi removed a child revision: D3202: Bug 1630534 - test sa for c++.
andi changed the repository for this revision from rMC m-c to rMOZILLACENTRAL mozilla-central.
andi removed a subscriber: phabqareview.
andi changed the repository for this revision from rMOZILLACENTRAL mozilla-central to rMC m-c.